Android tablet - TinyMCE editor allows all 6 heading sizes

[Rangi Daymond]

Environment: master.dev
Platform/s: Android versions 7 & 9 with Chrome and also Firefox

Release 20.10 uses TinyMCE version 5.0 which is now described on their web-site as 'legacy' for mobile, fixing this may require upgrading TinyMCE. Web site: https://www.tiny.cloud/docs/mobile/

Precondition: Logged in person has a page with a text block.

Steps:
1. Logged in user chooses to edit a text block (tap block), selects some text to make into a heading, and using the 'T' option selects to view the 'Styles' Headings options and selects a heading style (should only be 3 choices available).

Expected results: only three headings are available for selection (and when the updated page is viewed and the heading 'Inspected', it shows use of either h4, h5 or h6).

Actual result: there are 6 options available and if 'Heading 1' is selected, when the updated page is viewed and the heading 'Inspected', it shows use of h1.

Refer to Bug #1895213

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11437

[Lisa Seeto (lisaseeto)]

The proposed fix doesn't require an upgrade to the tinymce libraries. If an upgrade to 5.5 is needed we should create another bug for that to keep issues separate.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11437
Committed: https://git.mahara.org/mahara/mahara/commit/80c392874822bf5aaaa31b0a17c504af57a3a50d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 80c392874822bf5aaaa31b0a17c504af57a3a50d
Author: Lisa Seeto <email address hidden>
Date: Wed Nov 11 14:40:36 2020 +1300

Bug 1898502: Android tablet - TinyMCE editor allows all 6 heading sizes

- restrict the heading styles on mobile theme
- update README with change details

Change-Id: Id1c681dd26711d8483bb6490ba710e072a69229a
Signed-off-by: Lisa Seeto <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11440

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11440
Committed: https://git.mahara.org/mahara/mahara/commit/815637ad5ae05306c3fbe8f567807f44638c8222
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 815637ad5ae05306c3fbe8f567807f44638c8222
Author: Lisa Seeto <email address hidden>
Date: Wed Nov 11 14:40:36 2020 +1300

Bug 1898502: Android tablet - TinyMCE editor allows all 6 heading sizes

- restrict the heading styles on mobile theme
- update README with change details

Change-Id: Id1c681dd26711d8483bb6490ba710e072a69229a
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 80c392874822bf5aaaa31b0a17c504af57a3a50d)

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11451

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11605

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11650

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11650
Committed: https://git.mahara.org/mahara/mahara/commit/d3e374656ee7c930f0a631f0632664602c019744
Submitter: Lisa Seeto (<email address hidden>)
Branch: master

commit d3e374656ee7c930f0a631f0632664602c019744
Author: Lisa Seeto <email address hidden>
Date: Wed Nov 11 14:40:36 2020 +1300

Bug 1898502: Android tablet - TinyMCE editor allows all 6 heading sizes

- restrict the heading styles on mobile theme
- update README with change details

Change-Id: Ic9b2756039dce3ad9861dd826b60f846757add13

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11744