Entire resume block - debug information displayed

[Rangi Daymond]

Environment: cloud instance MYSQL 8.0 PHP7.4
Browser: Win10 Edge
Theme: Ocean

Precondition: account holder has a well populated Résumé

Steps:
1. Log in to an account that can create pages
2. Create a new page titled 'My Résumé'
3. Add a 'My entire résumé' block to the page with title 'My Résumé' & Save
4. Resize the block to fill the page width
5. Select to display the page

Expected result: the page displays correctly.
Actual result: The following error message is displayed after the page title & header but before the entire resume block. It is displayed 30+ times then underneath all the messages is the block title and its content. Please see the two attached screen shots; first a screen grab & second a full screen shot pasted

"[DBG] c1 (lib/dml.php:379) get_record_sql found more than one row. If you meant to retrieve more than one record, use get_records_*, otherwise check your code or database for inconsistencies"

[Kristina Hoeppner (kris-hoeppner)]

These are not errors bug debug information. I suspect that is due to the setup of the site as it injects data.

Please re-test on a different site that was set up normally. It is most likely not an issue in Mahara, but the way the DB was set up.

[Rangi Daymond (rangid)]

Bug Re-confirmed - retested in my local Postregres environment using Win10-Edge.

Please see attached screenshot. The number of messages (only 12 this time) displayed seem to be related to how much data is present in the resume (only standard first page of details entered - the previous screen shot shows the result when most resume fields were populated).

[Rangi Daymond (rangid)]

Note: Retesting by Rebecca found that it is the resizing of the block that triggers the error messages.

[Lisa Seeto (lisaseeto)]

This issue can also be tested with a person with a resume with just one field such as "Education history" filled out and the same resize steps.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11360

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11360
Committed: https://git.mahara.org/mahara/mahara/commit/b433c22bb54731d1c315c82d68a4551ad9164bb7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b433c22bb54731d1c315c82d68a4551ad9164bb7
Author: Lisa Seeto <email address hidden>
Date: Tue Oct 13 17:00:25 2020 +1300

Bug 1897676: Entire resume block - debug information displayed

NB: We are ignoring the multiple records found warnings
that are produced as a result of asynch json calls until we can
refactor that part of the code

- add IGNORE_MULTIPLE flag to ensure_record_exists
- remove old param comment

Change-Id: I39548cd157c9c2bfe82450bfddbe33696233a974
Signed-off-by: Lisa Seeto <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11379

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11379
Committed: https://git.mahara.org/mahara/mahara/commit/f97eaaa156b14128b5d5e7edfac3572967dac205
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit f97eaaa156b14128b5d5e7edfac3572967dac205
Author: Lisa Seeto <email address hidden>
Date: Tue Oct 13 17:00:25 2020 +1300

Bug 1897676: Entire resume block - debug information displayed

NB: We are ignoring the multiple records found warnings
that are produced as a result of asynch json calls until we can
refactor that part of the code

- add IGNORE_MULTIPLE flag to ensure_record_exists
- remove old param comment

Change-Id: I39548cd157c9c2bfe82450bfddbe33696233a974
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit b433c22bb54731d1c315c82d68a4551ad9164bb7)

[Robert Lyon (robertl-9)]

Once the patch https://reviews.mahara.org/#/c/11198/ the problem this is fixing should be solved but having ensure_record_exists() have the optional flag for strictness is still something good to have in the system