Sync syncthing 1.9.0~ds1-2 (universe) from Debian unstable (main)

[Andrej Shadura]

Please sync syncthing 1.9.0~ds1-2 (universe) from Debian unstable (main)

Explanation of the Ubuntu delta and why it can be dropped:
  * debian/patches/workaround-bad-test.patch:
    - Behavior of AuditService was racy (and always fail with golang 1.13).
      There is a time.Sleep in the tests that enabled to avoid it in golang
      1.12, but this now always fail with golang 1.13.
      New syncthing is refactored to avoid this, once we get a new release
      in sync from Debian.
  * debian/patches/workaround-bad-test.patch:
    - Behavior of AuditService was racy (and always fail with golang 1.13).
      There is a time.Sleep in the tests that enabled to avoid it in golang
      1.12, but this now always fail with golang 1.13.
      New syncthing is refactored to avoid this, once we get a new release
      in sync from Debian.

These patches are for an obsolete version of syncthing. The new version also fixes two bugs, LP: #1897223 and LP: #1847018.

Changelog entries since current groovy version 1.1.4~ds1-4ubuntu2:

syncthing (1.9.0~ds1-2) unstable; urgency=medium

  * badger-max-cache.patch: Don't use deprecated
    MaxCache option.
  * Depend on quic-go >=0.18.0.

 -- Alexandre Viau <email address hidden> Sun, 20 Sep 2020 00:47:13 -0400

syncthing (1.9.0~ds1-1) unstable; urgency=medium

  * New upstream version.

 -- Alexandre Viau <email address hidden> Wed, 16 Sep 2020 11:49:49 -0400

syncthing (1.8.0~ds1-1) unstable; urgency=medium

  * New upstream version. (Closes: #966466, #964363)
  * Remove quic-go.patch.
  * Refresh patches.
  * d/rules: adapt to new GUI files location.
  * Depend on golang-siphash-dev.
  * Depend on golang-github-dgraph-io-badger-dev.
  * Depend on go-ldap >=3.2.3.
  * Depend on golang-github-greatroar-blobloom-dev.
  * Remove many unused dependencies.

 -- Alexandre Viau <email address hidden> Wed, 16 Sep 2020 11:34:10 -0400

syncthing (1.5.0~ds1-5) unstable; urgency=medium

  * d/watch: point to correct releases page.

 -- Alexandre Viau <email address hidden> Sun, 30 Aug 2020 16:01:59 -0400

syncthing (1.5.0~ds1-4) unstable; urgency=medium

  * upstream/metada: add repository and repository-browse links.

 -- Alexandre Viau <email address hidden> Sun, 30 Aug 2020 14:33:57 -0400

syncthing (1.5.0~ds1-3) unstable; urgency=medium

  * Declare Rules-Requires-Root: no.

 -- Alexandre Viau <email address hidden> Sun, 30 Aug 2020 14:30:58 -0400

syncthing (1.5.0~ds1-2) unstable; urgency=medium

  * Allow multiple options in STRELAYSRV_OPTS. (Closes: #920677)

 -- Alexandre Viau <email address hidden> Sun, 30 Aug 2020 14:04:31 -0400

syncthing (1.5.0~ds1-1) unstable; urgency=medium

  * New upstream version.
  * Refresh tests-wait-longer.patch.
  * Refresh skip-failing-test.patch.
  * Refresh disable_test_host_check.patch.
  * Depend on golang-github-maruel-panicparse-dev.
  * Depend on golang-github-getsentry-raven-go-dev.
  * Depend on golang-github-lucas-clemente-quic-go-dev.
  * Don't build cmd/stcrashreceiver.
  * Depend on golang-github-ccding-go-stun >= 0.1.2.
  * Depend on golang-github-jackpal-go-nat-pmp-dev.
  * Depend on golang-github-shirou-gopsutil-dev.
  * Depend on golang-github-willf-bloom-dev.
  * d/rules: don't build stupgrades.
  * Create quic-go.patch.

 -- Alexandre Viau <email address hidden> Sun, 30 Aug 2020 13:51:50 -0400

syncthing (1.1.4~ds1-5) unstable; urgency=medium

  * Team upload.
  * Fix version string in package. (Closes: #931401)

 -- Stephen Gelman <email address hidden> Thu, 12 Mar 2020 19:59:32 -0500

[Dmitry Shachnev (mitya57)]

This bug was fixed in the package syncthing - 1.9.0~ds1-2
Sponsored for Andrej Shadura (andrew.sh)

---------------
syncthing (1.9.0~ds1-2) unstable; urgency=medium

  * badger-max-cache.patch: Don't use deprecated
    MaxCache option.
  * Depend on quic-go >=0.18.0.

 -- Alexandre Viau <email address hidden> Sun, 20 Sep 2020 00:47:13 -0400

syncthing (1.9.0~ds1-1) unstable; urgency=medium

  * New upstream version.

 -- Alexandre Viau <email address hidden> Wed, 16 Sep 2020 11:49:49 -0400

syncthing (1.8.0~ds1-1) unstable; urgency=medium

  * New upstream version. (Closes: #966466, #964363)
  * Remove quic-go.patch.
  * Refresh patches.
  * d/rules: adapt to new GUI files location.
  * Depend on golang-siphash-dev.
  * Depend on golang-github-dgraph-io-badger-dev.
  * Depend on go-ldap >=3.2.3.
  * Depend on golang-github-greatroar-blobloom-dev.
  * Remove many unused dependencies.

 -- Alexandre Viau <email address hidden> Wed, 16 Sep 2020 11:34:10 -0400

syncthing (1.5.0~ds1-5) unstable; urgency=medium

  * d/watch: point to correct releases page.

 -- Alexandre Viau <email address hidden> Sun, 30 Aug 2020 16:01:59 -0400

syncthing (1.5.0~ds1-4) unstable; urgency=medium

  * upstream/metada: add repository and repository-browse links.

 -- Alexandre Viau <email address hidden> Sun, 30 Aug 2020 14:33:57 -0400

syncthing (1.5.0~ds1-3) unstable; urgency=medium

  * Declare Rules-Requires-Root: no.

 -- Alexandre Viau <email address hidden> Sun, 30 Aug 2020 14:30:58 -0400

syncthing (1.5.0~ds1-2) unstable; urgency=medium

  * Allow multiple options in STRELAYSRV_OPTS. (Closes: #920677)

 -- Alexandre Viau <email address hidden> Sun, 30 Aug 2020 14:04:31 -0400

syncthing (1.5.0~ds1-1) unstable; urgency=medium

  * New upstream version.
  * Refresh tests-wait-longer.patch.
  * Refresh skip-failing-test.patch.
  * Refresh disable_test_host_check.patch.
  * Depend on golang-github-maruel-panicparse-dev.
  * Depend on golang-github-getsentry-raven-go-dev.
  * Depend on golang-github-lucas-clemente-quic-go-dev.
  * Don't build cmd/stcrashreceiver.
  * Depend on golang-github-ccding-go-stun >= 0.1.2.
  * Depend on golang-github-jackpal-go-nat-pmp-dev.
  * Depend on golang-github-shirou-gopsutil-dev.
  * Depend on golang-github-willf-bloom-dev.
  * d/rules: don't build stupgrades.
  * Create quic-go.patch.

 -- Alexandre Viau <email address hidden> Sun, 30 Aug 2020 13:51:50 -0400

syncthing (1.1.4~ds1-5) unstable; urgency=medium

  * Team upload.
  * Fix version string in package. (Closes: #931401)

 -- Stephen Gelman <email address hidden> Thu, 12 Mar 2020 19:59:32 -0500

[Dmitry Shachnev (mitya57)]

Hi Andrej!

Unfortunately, it now dep-waits on two golang packages:

https://launchpad.net/ubuntu/+source/syncthing/1.9.0~ds1-2/+build/20085802

I have synced golang-github-greatroar-blobloom, it was not present in Ubuntu at all and now is waiting in the NEW queue.

Regarding golang-github-lucas-clemente-quic-go, do you know if it's safe to update it from 0.17.2 to 0.18.0? Upstream diff looks quite scary, 246 changed files with 7,534 additions and 4,801 deletions: https://github.com/lucas-clemente/quic-go/compare/v0.17.2..v0.18.0.

If you think it's safe, can you please file a separate sync request for it? (Feel free to subscribe me.)

Because new syncthing is not built yet, I am setting the status to Fix Committed.

[Andrej Shadura (andrew.sh)]

Syncthing seems to be the only rdep of golang-github-lucas-clemente-quic-go, so I think it should be okay.

[Andrej Shadura (andrew.sh)]

Filed a sync request as LP: #1897779.

[Dmitry Shachnev (mitya57)]

Now golang-github-lucas-clemente-quic-go built fine, but syncthing itself FTBFS:

https://launchpadlibrarian.net/501315340/buildlog_ubuntu-groovy-amd64.syncthing_1.9.0~ds1-2_BUILDING.txt.gz

Can you look at it?

[Dmitry Shachnev (mitya57)]

Nevermind, I figured it out: https://launchpad.net/ubuntu/+source/syncthing/1.9.0~ds1-2ubuntu1.

[Dmitry Shachnev (mitya57)]

Now it dep-waits on armhf because badger FTBFS here (a retry didn't help):

https://launchpad.net/ubuntu/+source/badger/2.0.3-1/+build/19212777

[Andrej Shadura (andrew.sh)]

Filed https://bugs.debian.org/971898

[Andrej Shadura (andrew.sh)]

Who’d have thought a simple version bump would be this complicated!

[Andrej Shadura (andrew.sh)]

Apparently you need to update badger too: https://metadata.ftp-master.debian.org/changelogs/main/b/badger/unstable_changelog

[Dmitry Shachnev (mitya57)]

> Who’d have thought a simple version bump would be this complicated!

The story hasn't ended yet. Now we also have a failing autopkgtest: https://autopkgtest.ubuntu.com/packages/s/syncthing/groovy/amd64 (retried, maybe that will help).

> Apparently you need to update badger too

It is not urgent now, so I would better sync it after 20.10 is released and then syncthing will be in sync again.

[Dmitry Shachnev (mitya57)]

I tried a newer version from Debian and the autopkgtest still fails. The only failing test is:

=== RUN TestStressBufferPool
FAIL github.com/syncthing/syncthing/lib/protocol 2.706s

On ci.debian.net, it passes:

=== RUN TestStressBufferPool
    bufferpool_test.go:111: 4432 4335 172 [0 0 0 3 23 59 303 3873]
--- PASS: TestStressBufferPool (2.03s)

I have zero knowledge of Go, so I can't say why it's failing. Do you have any ideas? Maybe we should disable it?

[Dmitry Shachnev (mitya57)]

A test retry 2 days before Groovy release helped, so Groovy ships with new syncthing.

Finally marking this bug as fixed.

[Andrej Shadura (andrew.sh)]

Yaaaay, thanks a lot! 🙂