swift_rsync exited in 2/3 controllers after hard reboot

[Giulio Fidente]

While testing reboots, swift_rsync is only running on controller-1; it has status "exited(11)" on controller-0 and controller-2

This is a known issue [1] in handling stale pid files in rsyncd

1. https://<email address hidden>/msg32735.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/739859
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=43b5b0875d07bd3db29e83661aa32742dbef3544
Submitter: Zuul
Branch: master

commit 43b5b0875d07bd3db29e83661aa32742dbef3544
Author: Giulio Fidente <email address hidden>
Date: Tue Jul 7 23:47:12 2020 +0200

    Configure rsyncd without pid file for Swift

    There are known issues with stale pid file handling in rsyncd [1],
    which by consequence cause Swift to not start.

    This change disables use of pid file completely when deployed by
    the swift-storage conainer and depends on the addition of such
    a feature in the puppetlabs-rsync module [2]

    1. https://<email address hidden>/msg32735.html
    2. https://github.com/puppetlabs/puppetlabs-rsync/pull/120

    Closes-Bug: 1896605
    Change-Id: I81ad92793b8f115c046a678f4b2cc51d1014e3b6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/754862

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/754863

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/754862
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=af26d0ff3518c53394dad7a9c0349adc132b05f3
Submitter: Zuul
Branch: stable/ussuri

commit af26d0ff3518c53394dad7a9c0349adc132b05f3
Author: Giulio Fidente <email address hidden>
Date: Tue Jul 7 23:47:12 2020 +0200

    Configure rsyncd without pid file for Swift

    There are known issues with stale pid file handling in rsyncd [1],
    which by consequence cause Swift to not start.

    This change disables use of pid file completely when deployed by
    the swift-storage conainer and depends on the addition of such
    a feature in the puppetlabs-rsync module [2]

    1. https://<email address hidden>/msg32735.html
    2. https://github.com/puppetlabs/puppetlabs-rsync/pull/120

    Closes-Bug: 1896605
    Change-Id: I81ad92793b8f115c046a678f4b2cc51d1014e3b6
    (cherry picked from commit 43b5b0875d07bd3db29e83661aa32742dbef3544)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/754863
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2f8c408a9047df28e3d1cbd186378ea13d27b81a
Submitter: Zuul
Branch: stable/train

commit 2f8c408a9047df28e3d1cbd186378ea13d27b81a
Author: Giulio Fidente <email address hidden>
Date: Tue Jul 7 23:47:12 2020 +0200

    Configure rsyncd without pid file for Swift

    There are known issues with stale pid file handling in rsyncd [1],
    which by consequence cause Swift to not start.

    This change disables use of pid file completely when deployed by
    the swift-storage conainer and depends on the addition of such
    a feature in the puppetlabs-rsync module [2]

    1. https://<email address hidden>/msg32735.html
    2. https://github.com/puppetlabs/puppetlabs-rsync/pull/120

    Closes-Bug: 1896605
    Change-Id: I81ad92793b8f115c046a678f4b2cc51d1014e3b6
    (cherry picked from commit 43b5b0875d07bd3db29e83661aa32742dbef3544)
    (cherry picked from commit af26d0ff3518c53394dad7a9c0349adc132b05f3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.