Container driver failing to manage share server in Ubuntu Focal

[Douglas Viroel]

Description
===========
Manila fails to manage a share server and gives the following error:

"Error managing share server 45b20748-5dc7-49a7-b453-dff5b09e8fd3: manila.exception.ManilaException: Could not find OVS information related to container manila_3eaf6f56_3b87_48f8_8485_7a96d844e309."

Steps to reproduce
==================
- Manage a share server using Container driver in Ubuntu LTS Focal

Environment
===========
1. OpenStack Manila Ussuri release.

2. Storage backend: Containers

3. Network type: Neutron with Open vSwitch

4. Open vSwitch version 2.13.0

Logs & Configs
==============

Traceback: http://paste.openstack.org/show/798099/

[Douglas Viroel (dviroel)]

Looks like in Ubuntu Focal and Open vSwitch version 2.13.0 the behavior of how external-ids are stored in network interfaces was changed.
The command 'ovs-vsctl set interface veth1234567 external-ids:manila-container=container_name' doesn't add quotation marks around the value and also remove them if we added it manually:

1) without quotes:
$ sudo ovs-vsctl set interface vetha9e3dec external-ids:manila-container=manila_85fd0ad7_f614_46e3_bad3_f19eae36f6ea

$ sudo ovs-vsctl list interface vetha9e3dec | grep manila-container
external_ids : {attached-mac="fa:16:3e:a5:51:4b", iface-id="ea1a4107-4e47-45c5-8211-d60d80ac3b50", iface-status=active, manila-container=manila_85fd0ad7_f614_46e3_bad3_f19eae36f6ea}

2) adding quotes:
$ sudo ovs-vsctl set interface vetha9e3dec external-ids:manila-container="manila_85fd0ad7_f614_46e3_bad3_f19eae36f6ea"

$ sudo ovs-vsctl list interface vetha9e3dec | grep manila-container
external_ids : {attached-mac="fa:16:3e:a5:51:4b", iface-id="ea1a4107-4e47-45c5-8211-d60d80ac3b50", iface-status=active, manila-container=manila_85fd0ad7_f614_46e3_bad3_f19eae36f6ea}

And the code expected to have a quotation mark around container name:
https://opendev.org/openstack/manila/src/branch/master/manila/share/drivers/container/container_helper.py#L152

[Goutham Pacha Ravi (gouthamr)]

Patch in Review: https://review.opendev.org/#/c/752789

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/752789
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=40b12b23af17a70d22780dfefe1c6689698f9693
Submitter: Zuul
Branch: master

commit 40b12b23af17a70d22780dfefe1c6689698f9693
Author: Douglas Viroel <email address hidden>
Date: Sat Sep 19 07:10:34 2020 -0300

    Fix manage share server for container in Focal

    While managing share server using newest versions of the
    Open vSwitch, some of the interface external-ids are being
    saved without quotation marks around the container name.
    This causes the regex to fail on filtering the correct
    network interface and fail on manage share server operation.

    An alternative would be to always set the quotation mark
    around the container name, but this is not accepted and dropped
    by the Open vSwitch. Instead, the search regex was updated and
    now it accepts both modes:
    i) manila-container=manila_85fd0ad7_f614_46e3_bad3_f19eae36f6ea
    ii) manila-container="manila_85fd0ad7_f614_46e3_bad3_f19eae36f6ea"

    Closes-Bug: #1896322

    Change-Id: Ia24e7cd186cfa23fdfb267ce9b6155ff3d93d5d2
    Signed-off-by: Douglas Viroel <email address hidden>