[update] Fip test may start before the fip is ready and return false positive

[Sofer Athlan-Guyot]

Hi,

first noticed there https://bugzilla.redhat.com/show_bug.cgi?id=1878688

So we started to see <10seconds packets loss during train update. Looking closer to the ping log, we saw that we were missing the first packets.

It seems we start the ping test before the vm is ready. Now that we have 0% tolerance for ping loss during update this kind of false positive appears.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/752232

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/752232
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=306aa3b1996daddd2a81f6045ebbe47550bbc128
Submitter: Zuul
Branch: master

commit 306aa3b1996daddd2a81f6045ebbe47550bbc128
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Sep 16 14:33:35 2020 +0200

    Block on fip creation before starting the ping test.

    We wait for the fip to be reachable during ~1minutes before starting
    the ping test. We fail if it's not reachable in that time frame.

    Change-Id: I20cecd06834ef424599d9e281f0d6a6434f584a5
    Closes-Bug: #1895829

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/752639

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/752639
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=f9cc51478bfbcde96a81917754d320f2ba8ca03f
Submitter: Zuul
Branch: stable/ussuri

commit f9cc51478bfbcde96a81917754d320f2ba8ca03f
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Sep 16 14:33:35 2020 +0200

    Block on fip creation before starting the ping test.

    We wait for the fip to be reachable during ~1minutes before starting
    the ping test. We fail if it's not reachable in that time frame.

    Change-Id: I20cecd06834ef424599d9e281f0d6a6434f584a5
    Closes-Bug: #1895829
    (cherry picked from commit 306aa3b1996daddd2a81f6045ebbe47550bbc128)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/752663

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/752663
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=b7edf3112ee545b276db76417711b418d6d4e448
Submitter: Zuul
Branch: stable/train

commit b7edf3112ee545b276db76417711b418d6d4e448
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Sep 16 14:33:35 2020 +0200

    Block on fip creation before starting the ping test.

    We wait for the fip to be reachable during ~1minutes before starting
    the ping test. We fail if it's not reachable in that time frame.

    Change-Id: I20cecd06834ef424599d9e281f0d6a6434f584a5
    Closes-Bug: #1895829
    (cherry picked from commit 306aa3b1996daddd2a81f6045ebbe47550bbc128)
    (cherry picked from commit f9cc51478bfbcde96a81917754d320f2ba8ca03f)