Bootstrap OPAC: add support for Stripe v3 (Elements)

Bug #1895679 reported by Galen Charlton
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

Per bug 1774892, the Bootstrap OPAC should implement the new Stripe v3 API.

Evergreen master

Changed in evergreen:
status: New → Confirmed
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Jason Boyer (jboyer)
Jason Boyer (jboyer)
Changed in evergreen:
milestone: none → 3.6.2
Revision history for this message
Jason Boyer (jboyer) wrote :

Evergreen 3.6+

I've updated the Stripe support in the Bootstrap OPAC to match the v3 support in the TPAC. Branch is here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1895679_stripe_bootstrap / working/user/jboyer/lp1895679_stripe_bootstrap

Testing is very similar to the original notes in bug 1774892 but even simpler as nothing has changed in the staff client at all.

The original testing directions are here: https://bugs.launchpad.net/evergreen/+bug/1774892/comments/7

This will cover the specific changes to the Bootstrap OPAC:
1. Bill a patron in the staff client
2. Enable CC payments in the OUS editor
3. Set the Default CC Payment Processor to PayPal to enable the OPAC CC form
4. Use an Incognito window to login to the Bootstrap OPAC as the patron and go to My Account
5. Click the Charges option and choose Current Charges
6. Click Pay All Charges to load the payment form.

7. Apply the patches in the branch above

8. Repeat steps 4 - 6; the default payment form should load correctly and look the same as it did pre-patch
9. (Optional) Get a free Stripe account and retrieve a publishable key and secret key to process test payments and enter them in the OUS editor
10. Set Stripe as the Default Payment Processor
11. Repeat steps 4 - 6; the Stripe payment form should load correctly and look similar to the new Stripe payment form in the stock TPAC
12. If you completed step 9, process a payment to verify that everything is working as expected.

13. Hurray

tags: added: pullrequest
Changed in evergreen:
assignee: Jason Boyer (jboyer) → nobody
Revision history for this message
Garry Collum (gcollum) wrote :

I tested with a test stripe public and secret key. The functionality works great. The payments are made. All the screens are updated. The patron account is updated.

There's a couple of display issues.

In the credit card information screen there is text that reads "To ensure your necessary receipt information is not lost, enter your email address above and a receipt will be emailed to you. Otherwise, make certain you have a printed receipt in hand before closing the payment receipt screen." There's no input field for the email address.

On the "Your payment has been approved" page the date for each transaction shows as a timestamp. (Date: 2021-02-08T13:59:52-0500)

Revision history for this message
Jason Boyer (jboyer) wrote :

Thanks for testing Garry! The receipt is handled by an action trigger event template (money.payment_receipt.print). Since the default does have a fairly unfriendly bare timestamp a new bug could be entered to address that.

I'll take a look at the refund policy text; thanks for catching that.

Revision history for this message
Jason Boyer (jboyer) wrote :

I've added another commit to shorten and genericize the refund policy text. I didn't create a new one for Stripe because the use of stripe is unlikely to have any effect on a library's refund policy. I imagine it will frequently be customized anyway, but at least now it's not completely inaccurate. :)

Revision history for this message
Garry Collum (gcollum) wrote :

Tested again with the display change. It still works. A sign-off branch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=b47a060edd787ec714259dba2562b87dd2e912a4

tags: added: signedoff
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master and rel_3_6. Thanks, Jason and Garry!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.