export html check for directory readability needs to match directory used

Bug #1895617 reported by Lisa Seeto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Lisa Seeto
20.04
Fix Released
High
Unassigned
20.10
Fix Released
High
Lisa Seeto

Bug Description

In export/html/lib in the copy_static_files() we have the lines:

    if (is_readable($dir . $static)) {...etc...}

but when we later populate the directories we want to copy we use:
$directoriestocopy[$dir . '/' . $static] which uses a different path.
This also adds an extra unneccesary directory level '/'.
We need to make these paths consistent.

Lisa Seeto (lisaseeto)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11273

Changed in mahara:
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11273
Committed: https://git.mahara.org/mahara/mahara/commit/55eab846df7c51d2dfc1acf18cdd07157414ec97
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 55eab846df7c51d2dfc1acf18cdd07157414ec97
Author: Lisa Seeto <email address hidden>
Date: Tue Sep 15 16:31:11 2020 +1200

Bug 1895617: export html check for directory readability needs to match directory used

- remove the '/' from directoriestocopy array

Change-Id: I4462a7f0b17c153af750569f72f8476e9fe1977f
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11279

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11279
Committed: https://git.mahara.org/mahara/mahara/commit/e01b6b2009cda6cb4449e0128e6f6531b2f12efc
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit e01b6b2009cda6cb4449e0128e6f6531b2f12efc
Author: Lisa Seeto <email address hidden>
Date: Tue Sep 15 16:31:11 2020 +1200

Bug 1895617: export html check for directory readability needs to match directory used

- remove the '/' from directoriestocopy array

Change-Id: I4462a7f0b17c153af750569f72f8476e9fe1977f
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 55eab846df7c51d2dfc1acf18cdd07157414ec97)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.