"reboot required" juju status message disappears even if update-grub was not run
Bug #1895189 reported by
Zachary Zehring
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| charm-sysconfig |
Fix Released
|
Wishlist
|
Chi Wai CHAN | ||
Bug Description
When update-grub is false, grub updates don't occur automatically when config is altered. This means reboots do not apply grub-config-flags automatically as well. However, a reboot does clear the "reboot required" messages related to the change in the grub config. This makes it a bit confusing, as the operator can believe the grub config was applied, even though it wasn't.
It would be nice to have a message that update-grub is needed to be run that persists after reboots. Or some message about grub not being updated after such reboot.
Related branches
charm-sysconfig:bug/1895189
- Eric Chen: Approve
- Robert Gildein: Needs Fixing
- BootStack Reviewers: Pending requested
-
Diff: 215 lines (+116/-9)7 files modifiedsrc/actions.yaml (+3/-0)
src/actions/check-update-grub (+12/-0)
src/lib/lib_sysconfig.py (+34/-0)
src/reactive/sysconfig.py (+18/-5)
src/tests/functional/conftest.py (+0/-1)
src/tests/functional/test_deploy.py (+13/-3)
src/tests/unit/test_lib.py (+36/-0)
| description: | updated |
| description: | updated |
| description: | updated |
| Changed in charm-sysconfig: | |
| status: | New → Triaged |
| importance: | Undecided → Wishlist |
Revision history for this message
| Paul Goins (vultaire) wrote | #1 |
| tags: | added: bseng-338 |
| Changed in charm-sysconfig: | |
| assignee: | nobody → Chi Wai CHAN (raychan96) |
| status: | Triaged → Confirmed |
| Changed in charm-sysconfig: | |
| status: | Confirmed → In Progress |
| Changed in charm-sysconfig: | |
| status: | In Progress → Fix Released |
| Changed in charm-sysconfig: | |
| status: | Fix Released → Fix Committed |
| Changed in charm-sysconfig: | |
| milestone: | none → 22.08 |
| Changed in charm-sysconfig: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I just got hit by this. I was trying to figure out why 1G hugepages weren't working on a customer's hugepage-enabled compute nodes, despite having everything configured in the sysconfig charm. Upon digging deeper, I found that the config option was set after the subordinate was deployed, and since the update-grub config option was false (per recommended default), the grub configs were not rewritten. As the node has been rebooted since the change was made, there was no indication in Juju status that it was necessary to run "update-grub" to finalize the changes.