nfs-shares may contain multiple NFS mount points

Bug #1894817 reported by James Page
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
TrilioVault Data Mover Charm
Fix Released
Medium
James Page
TrilioVault Workload Manager Charm
Fix Released
Medium
James Page
charms.openstack
Fix Released
Medium
Unassigned

Bug Description

Hi,

We have some cases where we need to have multiple NFS shares for the same Trilio installation.
That can be either one NFS share for the OpenStack + other shares from other clouds that are also available to read; or multiple shares to write on purely simple.

Current Trilio charms do not support that.
The ongoing new charms should come with this support.

I can see on DM supports bind mounts for incremental copies [0], however we should also be able to pass multiple entries to DM config files as well.

[0]
https://github.com/openstack/charms.openstack/blob/2b143b9687d46dcd39144e15e3bf237b3c4f688c/charms_openstack/plugins/trilio.py#L158

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (master)

Reviewed: https://review.opendev.org/750317
Committed: https://git.openstack.org/cgit/openstack/charms.openstack/commit/?id=4c2486660fa3e201f3a39a0371d7bf310fe3ab3e
Submitter: Zuul
Branch: master

commit 4c2486660fa3e201f3a39a0371d7bf310fe3ab3e
Author: James Page <email address hidden>
Date: Tue Sep 8 11:49:49 2020 +0100

    trilio: Support multiple NFS share configurations

    TrilioVault supports use of multiple NFS shares using a comma
    separated list. Update the ghost-nfs-share action code to
    support this type of configuration.

    The assumption is that the order of shares provided to the
    action is the same as the order of shares in the nfs-shares
    configuration option in terms of replication between sites.

    Mismatched length lists will generate an exception which can
    be propagated back to the operator.

    Change-Id: I7d501a3e44d4e7c732e7625fa2a8cde9a34ff564
    Closes-Bug: 1894817

Changed in charms.openstack:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-trilio-data-mover (master)

Reviewed: https://review.opendev.org/750359
Committed: https://git.openstack.org/cgit/openstack/charm-trilio-data-mover/commit/?id=efcee2b9dfa4705ab01f72db91999fa918fb72a9
Submitter: Zuul
Branch: master

commit efcee2b9dfa4705ab01f72db91999fa918fb72a9
Author: James Page <email address hidden>
Date: Tue Sep 8 14:18:25 2020 +0100

    Support multiple NFS shares for bind mounts

    Rebuild to pickup changes to charms.openstack classes to support
    use of nfs-shares configuration options containing multiple
    comma separated nfs shares.

    Update description of action to reflect this change.

    Change-Id: If03387fa06ecf546a640b20415497800f7ef7d9d
    Closes-Bug: 1894817
    Func-Test-PR: https://github.com/openstack-charmers/zaza-openstack-tests/pull/410

Changed in charm-trilio-data-mover:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-trilio-wlm (master)

Reviewed: https://review.opendev.org/750358
Committed: https://git.openstack.org/cgit/openstack/charm-trilio-wlm/commit/?id=ab3d5a7fafb29ad98c4f4d92598e6b12b6e8e6e4
Submitter: Zuul
Branch: master

commit ab3d5a7fafb29ad98c4f4d92598e6b12b6e8e6e4
Author: James Page <email address hidden>
Date: Tue Sep 8 14:16:13 2020 +0100

    Support multiple NFS shares for bind mounts

    Rebuild to pickup changes to charms.openstack classes to support
    use of nfs-shares configuration options containing multiple
    comma separated nfs shares.

    Update description of action to reflect this change.

    Change-Id: I64ac3a7c2fa2f1662db055227ea2b885f9c2564f
    Closes-Bug: 1894817
    Func-Test-PR: https://github.com/openstack-charmers/zaza-openstack-tests/pull/410

Changed in charm-trilio-wlm:
status: In Progress → Fix Committed
James Page (james-page)
Changed in charm-trilio-data-mover:
milestone: none → 20.10
Changed in charm-trilio-wlm:
milestone: none → 20.10
James Page (james-page)
Changed in charm-trilio-data-mover:
importance: Undecided → Medium
Changed in charm-trilio-wlm:
importance: Undecided → Medium
Changed in charms.openstack:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-trilio-wlm (stable/20.08)

Fix proposed to branch: stable/20.08
Review: https://review.opendev.org/751756

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-trilio-data-mover (stable/20.08)

Fix proposed to branch: stable/20.08
Review: https://review.opendev.org/751757

Revision history for this message
James Page (james-page) wrote :

Picked for stable update as well

Changed in charm-trilio-wlm:
assignee: nobody → James Page (james-page)
Changed in charm-trilio-data-mover:
assignee: nobody → James Page (james-page)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/20.08)

Fix proposed to branch: stable/20.08
Review: https://review.opendev.org/751759

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/20.08)

Reviewed: https://review.opendev.org/751759
Committed: https://git.openstack.org/cgit/openstack/charms.openstack/commit/?id=388bb78f62db36a5ccf4e2177ab6e20696db63f6
Submitter: Zuul
Branch: stable/20.08

commit 388bb78f62db36a5ccf4e2177ab6e20696db63f6
Author: James Page <email address hidden>
Date: Tue Sep 8 11:49:49 2020 +0100

    trilio: Support multiple NFS share configurations

    TrilioVault supports use of multiple NFS shares using a comma
    separated list. Update the ghost-nfs-share action code to
    support this type of configuration.

    The assumption is that the order of shares provided to the
    action is the same as the order of shares in the nfs-shares
    configuration option in terms of replication between sites.

    Mismatched length lists will generate an exception which can
    be propagated back to the operator.

    Change-Id: I7d501a3e44d4e7c732e7625fa2a8cde9a34ff564
    Closes-Bug: 1894817
    (cherry picked from commit 4c2486660fa3e201f3a39a0371d7bf310fe3ab3e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-trilio-data-mover (stable/20.08)

Reviewed: https://review.opendev.org/751757
Committed: https://git.openstack.org/cgit/openstack/charm-trilio-data-mover/commit/?id=13de71a43a38c82cdb957ca61311d2ebeb968081
Submitter: Zuul
Branch: stable/20.08

commit 13de71a43a38c82cdb957ca61311d2ebeb968081
Author: James Page <email address hidden>
Date: Tue Sep 8 14:18:25 2020 +0100

    Support multiple NFS shares for bind mounts

    Rebuild to pickup changes to charms.openstack classes to support
    use of nfs-shares configuration options containing multiple
    comma separated nfs shares.

    Update description of action to reflect this change.

    Change-Id: If03387fa06ecf546a640b20415497800f7ef7d9d
    Closes-Bug: 1894817
    Func-Test-PR: https://github.com/openstack-charmers/zaza-openstack-tests/pull/410
    (cherry picked from commit efcee2b9dfa4705ab01f72db91999fa918fb72a9)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-trilio-wlm (stable/20.08)

Reviewed: https://review.opendev.org/751756
Committed: https://git.openstack.org/cgit/openstack/charm-trilio-wlm/commit/?id=c5a95f75102f5d90e2bbb4f729a28e874163c46b
Submitter: Zuul
Branch: stable/20.08

commit c5a95f75102f5d90e2bbb4f729a28e874163c46b
Author: James Page <email address hidden>
Date: Tue Sep 8 14:16:13 2020 +0100

    Support multiple NFS shares for bind mounts

    Rebuild to pickup changes to charms.openstack classes to support
    use of nfs-shares configuration options containing multiple
    comma separated nfs shares.

    Update description of action to reflect this change.

    Change-Id: I64ac3a7c2fa2f1662db055227ea2b885f9c2564f
    Closes-Bug: 1894817
    Func-Test-PR: https://github.com/openstack-charmers/zaza-openstack-tests/pull/410
    (cherry picked from commit ab3d5a7fafb29ad98c4f4d92598e6b12b6e8e6e4)

James Page (james-page)
Changed in charm-trilio-data-mover:
status: Fix Committed → Fix Released
Changed in charm-trilio-wlm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.