typo in osrandom.py

Bug #189466 reported by owen
4
Affects Status Importance Assigned to Milestone
paramiko
Fix Released
High
Robey Pointer

Bug Description

Redhat 4 update 5, stock python 2.3.4, paramiko 1.7.2, pycrypto 2.0.1

When running test.py, I immediately get:

Traceback (most recent call last):
  File "./test.py", line 146, in ?
    main()
  File "./test.py", line 111, in main
    SFTPTest.init_loopback()
  File "tests/test_sftp.py", line 129, in init_loopback
    tc.connect(username='slowdive', password='pygmalion')
  File "/usr/lib/python2.3/site-packages/paramiko/transport.py", line 931, in connect
    self.start_client()
  File "/usr/lib/python2.3/site-packages/paramiko/transport.py", line 398, in start_client
    raise e
NameError: global name '_def_urandom' is not defined

If I change line 47 of /usr/lib/python2.3/site-packages/paramiko/osrandom.py from:
return _def_urandom.read(bytes)
to:
return _dev_urandom.read(bytes)

The test runs.

Revision history for this message
Robey Pointer (robey) wrote :

grumble. why is that passing unit tests when so obviously broken?

Changed in paramiko:
assignee: nobody → robey
importance: Undecided → High
milestone: none → 1.7.3
status: New → Confirmed
Revision history for this message
Robey Pointer (robey) wrote :

fixed in @468.

Changed in paramiko:
status: Confirmed → Fix Committed
Robey Pointer (robey)
Changed in paramiko:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.