openstack-tox-py36-with-ovsdbapp-master periodic job is failing everyday since 28.08.2020

[Slawek Kaplonski]

Failure example: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b4c/periodic/opendev.org/openstack/neutron/master/openstack-tox-py36-with-ovsdbapp-master/b4c9514/testr_results.html

IMO it's failing after we merged https://review.opendev.org/#/c/745746/ but that has to be checked.

[Slawek Kaplonski (slaweq)]

This issue should be fixed with https://review.opendev.org/#/c/749537/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/749537
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6fc24afd9a7bf0156cdc94330823cb35a03e2602
Submitter: Zuul
Branch: master

commit 6fc24afd9a7bf0156cdc94330823cb35a03e2602
Author: Terry Wilson <email address hidden>
Date: Wed Sep 2 10:37:33 2020 -0500

    Use MagicMock for Connection object

    After https://review.opendev.org/#/c/745746/ there are new calls to
    'with self.lock' which fail in unit tests that only use a Mock object
    for the Connection that is passed to an API impl object. Switching to
    MagicMock fixes it.

    Closes-Bug: #1893965

    Change-Id: Icbcb5e004dfa777877d1865a5018262344c7e415