(storage-)ceph-relation-{joined,changed} fails with TypeError: 'str' object is not callable

[Aurelien Lourot]

2020-08-28 14:36:41 ERROR juju-log storage-ceph:15: Hook error:
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-gnocchi-0/.venv/lib/python3.6/site-packages/charms/reactive/__init__.py", line 74, in main
    bus.dispatch(restricted=restricted_mode)
  File "/var/lib/juju/agents/unit-gnocchi-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 390, in dispatch
    _invoke(other_handlers)
  File "/var/lib/juju/agents/unit-gnocchi-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 359, in _invoke
    handler.invoke()
  File "/var/lib/juju/agents/unit-gnocchi-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 181, in invoke
    self._action(*args)
  File "/var/lib/juju/agents/unit-gnocchi-0/charm/reactive/gnocchi_handlers.py", line 163, in configure_ceph
    key = ceph.key()
TypeError: 'str' object is not callable

Happened here: https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-gnocchi/748631/1/18828/index.html

This is due to a recent change to the interface and we need to do the same change as here: https://review.opendev.org/#/c/748139/4/src/reactive/manila_ganesha.py

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/748806

[Aurelien Lourot (aurelien-lourot)]

I suspect this line is affected as well: https://github.com/openstack/charm-trilio-data-mover/blob/master/src/reactive/data_mover_handlers.py#L71

[Aurelien Lourot (aurelien-lourot)]

I confirm that when running the trilio-data-mover smoke tests we hit

2020-08-29 11:58:01 DEBUG ceph-relation-changed Traceback (most recent call last):
2020-08-29 11:58:01 DEBUG ceph-relation-changed File "/var/lib/juju/agents/unit-trilio-data-mover-1/charm/hooks/ceph-relation-changed", line 22, in <module>
2020-08-29 11:58:01 DEBUG ceph-relation-changed main()
2020-08-29 11:58:01 DEBUG ceph-relation-changed File "/var/lib/juju/agents/unit-trilio-data-mover-1/.venv/lib/python3.6/site-packages/charms/reactive/__init__.py", line 74, in main
2020-08-29 11:58:01 DEBUG ceph-relation-changed bus.dispatch(restricted=restricted_mode)
2020-08-29 11:58:01 DEBUG ceph-relation-changed File "/var/lib/juju/agents/unit-trilio-data-mover-1/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 390, in dispatch
2020-08-29 11:58:01 DEBUG ceph-relation-changed _invoke(other_handlers)
2020-08-29 11:58:01 DEBUG ceph-relation-changed File "/var/lib/juju/agents/unit-trilio-data-mover-1/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 359, in _invoke
2020-08-29 11:58:01 DEBUG ceph-relation-changed handler.invoke()
2020-08-29 11:58:01 DEBUG ceph-relation-changed File "/var/lib/juju/agents/unit-trilio-data-mover-1/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 181, in invoke
2020-08-29 11:58:01 DEBUG ceph-relation-changed self._action(*args)
2020-08-29 11:58:01 DEBUG ceph-relation-changed File "/var/lib/juju/agents/unit-trilio-data-mover-1/charm/reactive/data_mover_handlers.py", line 71, in configure_ceph
2020-08-29 11:58:01 DEBUG ceph-relation-changed charm_instance.configure_ceph_keyring(ceph.key())
2020-08-29 11:58:01 DEBUG ceph-relation-changed TypeError: 'str' object is not callable
2020-08-29 11:58:01 ERROR juju.worker.uniter.operation runhook.go:132 hook "ceph-relation-changed" failed: exit status 1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/748807

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748806
Committed: https://git.openstack.org/cgit/openstack/charm-gnocchi/commit/?id=0ee741575c6a6a203c8238a50ef021607d29d00a
Submitter: Zuul
Branch: master

commit 0ee741575c6a6a203c8238a50ef021607d29d00a
Author: Aurelien Lourot <email address hidden>
Date: Sat Aug 29 11:18:35 2020 +0200

    Fix storage-ceph-relation-joined error

    TypeError: 'str' object is not callable
    After recent interface change

    Change-Id: I794224b5d0750e100cdb62d1b03140b87e117ea8
    Closes-Bug: #1893445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748807
Committed: https://git.openstack.org/cgit/openstack/charm-trilio-data-mover/commit/?id=50c11d0e995bec63bd9bf52d47750edd84b0f98a
Submitter: Zuul
Branch: master

commit 50c11d0e995bec63bd9bf52d47750edd84b0f98a
Author: Aurelien Lourot <email address hidden>
Date: Sat Aug 29 14:12:50 2020 +0200

    Fix ceph-relation-changed error

    TypeError: 'str' object is not callable
    After recent interface change

    Func-Test-Pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/400
    Change-Id: I7a45b1ffe7d71bd44201a72510d6b56a1e1a4824
    Closes-Bug: #1893445

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/20.08
Review: https://review.opendev.org/751804

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/751804
Committed: https://git.openstack.org/cgit/openstack/charm-trilio-data-mover/commit/?id=992eb88f5e156c4e283786a13acdf1b43262c0a4
Submitter: Zuul
Branch: stable/20.08

commit 992eb88f5e156c4e283786a13acdf1b43262c0a4
Author: Aurelien Lourot <email address hidden>
Date: Sat Aug 29 14:12:50 2020 +0200

    Fix ceph-relation-changed error

    TypeError: 'str' object is not callable
    After recent interface change

    Change-Id: I7a45b1ffe7d71bd44201a72510d6b56a1e1a4824
    Closes-Bug: #1893445
    (cherry picked from commit 50c11d0e995bec63bd9bf52d47750edd84b0f98a)