Octavia deployment fails (ussuri latest, centos8)

[Wojciech]

Description
===========
Deploying Octavia on stack create or update using
/usr/share/openstack-tripleo-heat-templates/environments/services/octavia.yaml template
ends with error:

TASK [include_role : octavia-controller-check] ******************************************************************************************************************************************
task path: /usr/share/ansible/tripleo-playbooks/octavia-files.yaml:39
ERROR! the role 'octavia-controller-check' was not found in /usr/share/ansible/tripleo-playbooks/roles:/home/stack/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles:/usr/share/ansible/tripleo-playbooks

The error appears to be in '/usr/share/ansible/tripleo-playbooks/octavia-files.yaml': line 40, column 15, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

    - include_role:
        name: octavia-controller-check
              ^ here

it's a typo in templates as it should be

octavia_controller_check

but correcting this issue generates next errors for deployment on all (3) control nodes:

fatal: [ctl-0]: FAILED! => {
    "msg": "The conditional check 'stack_action == 'UPDATE'' failed. The error was: An unhandled exception occurred while templating '{{ stack_action }}'. Error was a <class 'ansible.errors.AnsibleError'>, original message: An unhandled exception occurred while templating '{{ stack_action }}'. Error was a <class 'ansible.errors.AnsibleError'>, original message: An unhandled exception occurred while templating '{{ stack_action }}'. Error was a <class 'ansible.errors.AnsibleError'>, original message: An unhandled exception occurred while templating '{{ stack_action }}'. Error was a <class 'ansible.errors.AnsibleError'>, original message: An unhandled exception occurred while templating '{{ stack_action }}'. Error was a <class 'ansible.errors.AnsibleError'>, original message: An unhandled exception occurred while templating '{{ stack_action }}'.

witch is related to block:

  tasks:
    - include_role:
        name: octavia-controller-check
      when:
        - generate_certs | bool
        - stack_action == 'UPDATE'

in:
/usr/share/ansible/tripleo-playbooks/octavia-files.yaml

and also in:

/usr/share/ansible/roles/octavia_overcloud_config/tasks/main.yml
in block:

- import_tasks: check_existing_certs.yml
  when:
    - stack_action == 'UPDATE'
    - generate_certs | bool

regards

WS

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/747725

[Brent Eagles (beagles)]

patch submitted https://review.opendev.org/#/c/747725/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747725
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=9d2f99f87c36e4043d1854258bb7b67367f4ede3
Submitter: Zuul
Branch: master

commit 9d2f99f87c36e4043d1854258bb7b67367f4ede3
Author: Brent Eagles <email address hidden>
Date: Mon Aug 24 10:50:23 2020 -0230

    Fix role name typo in octavia playbook

    octavia-controller-check should be octavia_controller_check. Also
    removes symlink that should no longer be required.

    Change-Id: I232aa4d8af134ce3403b12a15e06e378ad418d58
    Closes-Bug: #1892512

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/750202

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/750202
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=8b38513bb8cbc927cd4d9cee56cb460eb1cb5326
Submitter: Zuul
Branch: stable/ussuri

commit 8b38513bb8cbc927cd4d9cee56cb460eb1cb5326
Author: Brent Eagles <email address hidden>
Date: Mon Aug 24 10:50:23 2020 -0230

    Fix role name typo in octavia playbook

    octavia-controller-check should be octavia_controller_check. Also
    removes symlink that should no longer be required.

    Change-Id: I232aa4d8af134ce3403b12a15e06e378ad418d58
    Closes-Bug: #1892512
    (cherry picked from commit 9d2f99f87c36e4043d1854258bb7b67367f4ede3)

[Brent Eagles (beagles)]

In train, the roles have '-'s instead of '_' (hyphens instead of underscores) and the octavia-controller-check symbolic link is in place so the backport isn't required and I'm removing the train backport tag.

[Brent Eagles (beagles)]

Was just informed that the symbolic link isn't installed so I'm adding the backport potential flag back.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/754079

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/754079
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=fce0d3381ca7fb9574af24b09e6d620435ff2012
Submitter: Zuul
Branch: stable/train

commit fce0d3381ca7fb9574af24b09e6d620435ff2012
Author: Brent Eagles <email address hidden>
Date: Mon Aug 24 10:50:23 2020 -0230

    Fix role name typo in octavia playbook

    octavia-controller-check should be octavia_controller_check. Also
    removes symlink that should no longer be required.

    Change-Id: I232aa4d8af134ce3403b12a15e06e378ad418d58
    Closes-Bug: #1892512
    (cherry picked from commit 9d2f99f87c36e4043d1854258bb7b67367f4ede3)
    (cherry picked from commit 8b38513bb8cbc927cd4d9cee56cb460eb1cb5326)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 0.6.0 release.