Option debug missing in revision 30

[Diko Parvanov]

The config option 'debug' is there in revision 29, but not in revision 30.

https://jaas.ai/keystone-ldap/29 vs https://jaas.ai/keystone-ldap/30

https://opendev.org/openstack/charm-keystone-ldap/commit/8b85c27c2c73eb0262fc396e84184ce93d466513

Was there no effect applying the debug option at all?

[Alex Kavanagh (ajkavanagh)]

Yes, the debug option was removed here:

$ git show 3f72380
commit 3f72380e220d44b3886b29f14273bb64d7679ee2 (refs/changes/60/728660/1)
Author: Frode Nordahl <email address hidden>
Date: Sat May 16 23:29:14 2020 +0200

    Remove inherited configuration options invalid for charm

    Change-Id: I01cd3a3f53b09edb46398c7652ba19a6b1df4623
    Closes-Bug: #1879088

diff --git a/src/layer.yaml b/src/layer.yaml
index e84e9fd..62998cc 100644
--- a/src/layer.yaml
+++ b/src/layer.yaml
@@ -4,3 +4,12 @@ options:
     use_venv: True
     include_system_packages: False
 repo: https://github.com/openstack/charm-keystone-ldap.git
+config:
+ deletes:
+ - debug
+ - verbose
+ - use-internal-endpoints
+ - use-syslog
+ - ssl_ca
+ - ssl_cert
+ - ssl_key

A quick look at the charm's templates does indeed indicate that it didn't do anything.

The reactive charms inherit lower layers when building; debug is in layer-openstack IIRC, and so it probably got included by accident. This 'corrected' the charm by removing the option that doesn't do anything.