Mahara

Undefined variable: duplicates error when updating SAML metadata in SAML instance

Bug #1892256 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
19.04
Fix Released
High
Unassigned
Mahara 19.04.7
19.10
Fix Released
High
Unassigned
Mahara 19.10.5
20.04
Fix Released
High
Unassigned
Mahara 20.04.2
20.10
Fix Released
High
Robert Lyon
Mahara 20.10.0

Bug Description

This is because we can't chain the db query result and finding the resultant object value in the same "if" statement

We need to break this down into testable parts

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
milestone: none → 20.10.0
summary: - Error when updating SAML metadata in SAML instance
+ Undefined variable: duplicates error when updating SAML metadata in SAML
+ instance
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11159

Robert Lyon (robertl-9)
Changed in mahara:
importance: Medium → High
Revision history for this message
Lisa Seeto (lisaseeto) wrote :

I verified this fix by setting up two institutions with the same metadata then slightly changing the metadata in one of the institution's settings in order to trigger another configuration save, saved the SAML configuration and then saved the institution, producing the error. I then applied the patch, repeated the steps and was able to successfully save the institution without any error messages or warnings

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11159
Committed: https://git.mahara.org/mahara/mahara/commit/ce09693205cb9b8fe8a2f949cb09aeca2c197dc4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ce09693205cb9b8fe8a2f949cb09aeca2c197dc4
Author: Robert Lyon <email address hidden>
Date: Thu Aug 20 09:33:19 2020 +1200

Bug 1892256: Restructure code to avoid Undefined variable: duplicates

Change-Id: Ia93f67a0aa3558dda1ae7677b84202f0f07e446e
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11249

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11249
Committed: https://git.mahara.org/mahara/mahara/commit/1aa7cc1343d9106ea985e60fd23e81310947b6de
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 1aa7cc1343d9106ea985e60fd23e81310947b6de
Author: Robert Lyon <email address hidden>
Date: Thu Aug 20 09:33:19 2020 +1200

Bug 1892256: Restructure code to avoid Undefined variable: duplicates

Change-Id: Ia93f67a0aa3558dda1ae7677b84202f0f07e446e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit ce09693205cb9b8fe8a2f949cb09aeca2c197dc4)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11250

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11251

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11251
Committed: https://git.mahara.org/mahara/mahara/commit/d18817bdeb1d095140f7f5870dd4ea031105f717
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit d18817bdeb1d095140f7f5870dd4ea031105f717
Author: Robert Lyon <email address hidden>
Date: Thu Aug 20 09:33:19 2020 +1200

Bug 1892256: Restructure code to avoid Undefined variable: duplicates

Change-Id: Ia93f67a0aa3558dda1ae7677b84202f0f07e446e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit ce09693205cb9b8fe8a2f949cb09aeca2c197dc4)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11250
Committed: https://git.mahara.org/mahara/mahara/commit/b9513c750d5fb8da22a6ada5a9d7fcae4f7a9898
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit b9513c750d5fb8da22a6ada5a9d7fcae4f7a9898
Author: Robert Lyon <email address hidden>
Date: Thu Aug 20 09:33:19 2020 +1200

Bug 1892256: Restructure code to avoid Undefined variable: duplicates

Change-Id: Ia93f67a0aa3558dda1ae7677b84202f0f07e446e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit ce09693205cb9b8fe8a2f949cb09aeca2c197dc4)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.