Train standalone jobs are failing check/gate - unable to resolve tripleo_deploy_control_virtual_ip

Bug #1892078 reported by Ronelle Landy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
chandan kumar

Bug Description

Since https://github.com/openstack/tripleo-quickstart-extras/commit/63c1365d94b2246a0be8580026aff001e6d8fce8 merged, standalone jobs on train and earlier releases are failing with the following error:

2020-08-18 15:51:05.327886 | primary | TASK [tripleo.operator.tripleo_deploy : Setup standalone deploy facts] *********
2020-08-18 15:51:05.327933 | primary | Tuesday 18 August 2020 15:51:05 +0000 (0:00:00.050) 0:15:46.555 ********
2020-08-18 15:51:05.384611 | primary | fatal: [undercloud]: FAILED! => {}
2020-08-18 15:51:05.384666 | primary |
2020-08-18 15:51:05.384677 | primary | MSG:
2020-08-18 15:51:05.384698 | primary |
2020-08-18 15:51:05.384711 | primary | The task includes an option with an undefined variable. The error was: the inline if-expression on line 1 evaluated to false and no else section was defined.
2020-08-18 15:51:05.384720 | primary |
2020-08-18 15:51:05.384728 | primary | The error appears to be in '/home/zuul/workspace/.quickstart/share/ansible/collections/ansible_collections/tripleo/operator/roles/tripleo_deploy/tasks/main.yml': line 8, column 3, but may
2020-08-18 15:51:05.384737 | primary | be elsewhere in the file depending on the exact syntax problem.
2020-08-18 15:51:05.384746 | primary |
2020-08-18 15:51:05.384753 | primary | The offending line appears to be:
2020-08-18 15:51:05.384762 | primary |
2020-08-18 15:51:05.384769 | primary |
2020-08-18 15:51:05.384777 | primary | - name: Setup standalone deploy facts
2020-08-18 15:51:05.384786 | primary | ^ here
2020-08-18 15:51:05.384794 | primary |

This clause:
- name: Check whether control plane defaults to HA
  set_fact:
    tripleo_deploy_ha_control_plane: "{{ release not in ['newton', 'ocata', 'pike', 'queens', 'rocky', 'stein', 'train'] }}"

means that tripleo_deploy_ha_control_plane will be undefined in releases train and earlier and there is no else condition on:

 (standalone_ha_control_virtual_ip|default() if tripleo_deploy_ha_control_plane)

Tags: ci
Ronelle Landy (rlandy)
Changed in tripleo:
milestone: none → victoria-3
assignee: nobody → Ronelle Landy (rlandy)
importance: Undecided → Critical
status: New → Triaged
tags: added: ci
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
Ronelle Landy (rlandy) wrote :

Related change:
https://review.opendev.org/746772 Switch logic on when to use control_virtual_ip

Changed in tripleo:
assignee: Ronelle Landy (rlandy) → chandan kumar (chkumar246)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-quickstart-extras (master)

Reviewed: https://review.opendev.org/746772
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=a961129b65105c9ac89642ff2c88ed2d39e5c5d8
Submitter: Zuul
Branch: master

commit a961129b65105c9ac89642ff2c88ed2d39e5c5d8
Author: Ronelle Landy <email address hidden>
Date: Tue Aug 18 13:03:23 2020 -0400

    Switch logic on when to use control_virtual_ip

    Without an else clause, the variable will be undefined
    and fail on releases where tripleo_deploy_control_virtual_ip
    is not set.

    This review switches the order so that the condition will
    resolev on either situation.

    Fixes failing commit:
    https://github.com/openstack/tripleo-quickstart-extras/commit/63c1365d94b2246a0be8580026aff001e6d8fce8

    Closes-Bug: #1892078
    Change-Id: I7f9019eff1a19da24a1f91fc5bc52c279520ca87

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
chandan kumar (chkumar246) wrote :

we have tested it against stable/train using dnm patch https://review.opendev.org/#/c/746835/ and
tripleo-ci-centos-8-standalone SUCCESS in 1h 45m 50s. We will monitor it for few days. Then we can close the bug.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.