Mahara

Instituion static page edit not disabled

  1. Series 20.10
  2. Bug #1891939
Bug #1891939 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
19.10
Fix Released
Medium
Unassigned
Mahara 19.10.5
20.04
Fix Released
Medium
Unassigned
Mahara 20.04.2
20.10
Fix Released
Medium
Cecilia Vela Gurovic
Mahara 20.10.0

Bug Description

Should not allow to edit an institution static page while the 'Use site default' is set to yes

To test
- Have an institution
- Go to Admin menu -> Institutions -> static pages
- Set 'Use site default' to yes

expected result: the tinyMCE editor is greyed out and you are not allowed to make changes
actual result: the tinyMCE editor is enabled

See original description
Cecilia Vela Gurovic (ceciliavg)
description: updated
Changed in mahara:
milestone: none → 20.10.0
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
status: New → In Progress
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
importance: Undecided → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11149

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

when upgrading to TinyMCE 5, on commit ada3e2cd6f87c8d22980f28ffe0dc957308796aa
on the file theme/raw/sass/lib/_tinymce.scss
the mce-tinymce class from the editor is changed to tox-tinymce

we should remove the references from the code to mce-tinymce class in the jQuery selector and styles
since they won't return any object.

other places to check:

Make sure the tinyMCE editor is visible when is located inside a modal, for example when editing a text blocktype, an dit has the correct width on the rest of the places we use tinymce

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11149
Committed: https://git.mahara.org/mahara/mahara/commit/2a20af65e1a2d175bfca49de5e7a020f7755df6f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2a20af65e1a2d175bfca49de5e7a020f7755df6f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Aug 18 11:09:14 2020 +1200

Bug 1891939: remove references to mce-tinymce class

when upgrading to TinyMCE 5, on commit ada3e2cd6f87c8d22980f28ffe0dc957308796aa
the theme/raw/sass/lib/_tinymce.scss

the mce-tinymce class from the editor is changed to tox-tinymce

we should remove the references from the code to that class
in the jQuery selector and styles since they won't return any object.

behatnotneeded

Change-Id: Ia981e2c2599b4fb1ca6ade48bd376cca0cebbc85

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11162

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11163

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11162
Committed: https://git.mahara.org/mahara/mahara/commit/5651b764be185ed905beb9c3064e6a9be0c8b293
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 5651b764be185ed905beb9c3064e6a9be0c8b293
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Aug 18 11:09:14 2020 +1200

Bug 1891939: remove references to mce-tinymce class

when upgrading to TinyMCE 5, on commit ada3e2cd6f87c8d22980f28ffe0dc957308796aa
the theme/raw/sass/lib/_tinymce.scss

the mce-tinymce class from the editor is changed to tox-tinymce

we should remove the references from the code to that class
in the jQuery selector and styles since they won't return any object.

behatnotneeded

Change-Id: Ia981e2c2599b4fb1ca6ade48bd376cca0cebbc85
(cherry picked from commit 2a20af65e1a2d175bfca49de5e7a020f7755df6f)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11163
Committed: https://git.mahara.org/mahara/mahara/commit/0493cecc8491214be8c7473d2f3e0cdd77774d3b
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 0493cecc8491214be8c7473d2f3e0cdd77774d3b
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Aug 18 11:09:14 2020 +1200

Bug 1891939: remove references to mce-tinymce class

when upgrading to TinyMCE 5, on commit ada3e2cd6f87c8d22980f28ffe0dc957308796aa
the theme/raw/sass/lib/_tinymce.scss

the mce-tinymce class from the editor is changed to tox-tinymce

we should remove the references from the code to that class
in the jQuery selector and styles since they won't return any object.

behatnotneeded

Change-Id: Ia981e2c2599b4fb1ca6ade48bd376cca0cebbc85
(cherry picked from commit 2a20af65e1a2d175bfca49de5e7a020f7755df6f)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.