hard-coded vars_from in t-h-t prevents proper podman version pinning

Bug #1891465 reported by Cédric Jeanneret
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Cédric Jeanneret

Bug Description

Hello,

The following line in t-h-t prevents a proper podman version pinning needed in order to avoid some issues in some cases, especially when we take podman from specific module stream, as it's the case for osp-16.1 on rhel-8.2:
https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/podman/podman-baremetal-ansible.yaml#L109

This line is probably due to the fact we call "tasks_from" in order to get only a subset of the role - this tasks file doesn't have the include_vars we can see in the "main.yaml" here:
https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/podman/podman-baremetal-ansible.yaml#L109

In any cases, the fixed "vars_from" will create an issue sooner or later.

So we probably need to:
- add that same logic in, at least, the tripleo_podman_install:
https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_podman_install.yml
- maybe as well in the tripleo_docker_purge (due to the docker package listing):
https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_docker_purge.yml
- remove the vars_from in t-h-t

We can also make the include_vars optional in the tasks files, using a "when <var> != []" or something.

Finally, we can "enforce" the redhat.yml inclusion by adding it at the very end of the tested files, though it shouldn't be necessary.

These changes must go down to train in order to make the podman pinning logic actually work (it's not the case now, of course, with this hard-coded thing):
https://review.opendev.org/#/q/I9d8ba2818c7b00893473360b8098ae5cdecbb256

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-ansible (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/746124

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/746125

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/746124
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=11f365d00b444727f61b643acff30771c0453ec9
Submitter: Zuul
Branch: master

commit 11f365d00b444727f61b643acff30771c0453ec9
Author: Cédric Jeanneret <email address hidden>
Date: Thu Aug 13 12:53:19 2020 +0200

    Ensure those two tasks are compatible with t-h-t import

    In t-h-t, we call "tasks_from" in order to exclusively call those two
    files in different location.
    We therefore need to ensure we actually set the right variables, even in
    this case.

    Change-Id: Ifbccd663373f0e29301810dcc088b83d968f6203
    Related-Bug: #1891465

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-ansible (stable/ussuri)

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/746441

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-ansible (stable/ussuri)

Reviewed: https://review.opendev.org/746441
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=5781caccd593a079e20eb353e8d62393e5d933ba
Submitter: Zuul
Branch: stable/ussuri

commit 5781caccd593a079e20eb353e8d62393e5d933ba
Author: Cédric Jeanneret <email address hidden>
Date: Thu Aug 13 12:53:19 2020 +0200

    Ensure those two tasks are compatible with t-h-t import

    In t-h-t, we call "tasks_from" in order to exclusively call those two
    files in different location.
    We therefore need to ensure we actually set the right variables, even in
    this case.

    Change-Id: Ifbccd663373f0e29301810dcc088b83d968f6203
    Related-Bug: #1891465
    (cherry picked from commit 11f365d00b444727f61b643acff30771c0453ec9)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/746125
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=20131fd662071037e9aaae1960ac373675883f67
Submitter: Zuul
Branch: master

commit 20131fd662071037e9aaae1960ac373675883f67
Author: Cédric Jeanneret <email address hidden>
Date: Thu Aug 13 12:52:08 2020 +0200

    Do not hard-code vars_from

    This break the ability to fix packages depending on the OS.

    Change-Id: I2500200eba392888015796ec93623df089e8d31d
    Closes-Bug: #1891465
    Depends-On: https://review.opendev.org/746124

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-ansible (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/746637

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/746638

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/746639

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/ussuri)

Reviewed: https://review.opendev.org/746638
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=701841df54030ab8b36d1bdb970f81621d0062e9
Submitter: Zuul
Branch: stable/ussuri

commit 701841df54030ab8b36d1bdb970f81621d0062e9
Author: Cédric Jeanneret <email address hidden>
Date: Thu Aug 13 12:52:08 2020 +0200

    Do not hard-code vars_from

    This break the ability to fix packages depending on the OS.

    Change-Id: I2500200eba392888015796ec93623df089e8d31d
    Closes-Bug: #1891465
    Depends-On: https://review.opendev.org/746441
    (cherry picked from commit 20131fd662071037e9aaae1960ac373675883f67)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-ansible (stable/train)

Reviewed: https://review.opendev.org/746637
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=dc963ce0b76a511d182ad08b74ffe57b5a4b4a33
Submitter: Zuul
Branch: stable/train

commit dc963ce0b76a511d182ad08b74ffe57b5a4b4a33
Author: Cédric Jeanneret <email address hidden>
Date: Thu Aug 13 12:53:19 2020 +0200

    Ensure those two tasks are compatible with t-h-t import

    In t-h-t, we call "tasks_from" in order to exclusively call those two
    files in different location.
    We therefore need to ensure we actually set the right variables, even in
    this case.

    Change-Id: Ifbccd663373f0e29301810dcc088b83d968f6203
    Related-Bug: #1891465
    (cherry picked from commit 11f365d00b444727f61b643acff30771c0453ec9)
    (cherry picked from commit 5781caccd593a079e20eb353e8d62393e5d933ba)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/746639
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=48f068452bd5c2111b754df750bfa61a26a51e43
Submitter: Zuul
Branch: stable/train

commit 48f068452bd5c2111b754df750bfa61a26a51e43
Author: Cédric Jeanneret <email address hidden>
Date: Thu Aug 13 12:52:08 2020 +0200

    Do not hard-code vars_from

    This break the ability to fix packages depending on the OS.

    Change-Id: I2500200eba392888015796ec93623df089e8d31d
    Closes-Bug: #1891465
    Depends-On: https://review.opendev.org/746637
    (cherry picked from commit 20131fd662071037e9aaae1960ac373675883f67)
    (cherry picked from commit 701841df54030ab8b36d1bdb970f81621d0062e9)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.