duplicate vars under gcc-10

[Dave Jones]

Due to the -fno-common default in gcc-10 several variables raise duplicate declaration errors during compilation.

A patch derived from upstream's fix for the same issue is available from the following branch:

https://code.launchpad.net/~waveform/ubuntu/+source/open-iscsi/+git/open-iscsi/+ref/fix-duplicate-vars

With test builds in the following PPA:

https://launchpad.net/~waveform/+archive/ubuntu/open-iscsi

[Rafael David Tinoco (rafaeldtinoco)]

Thanks Dave,

I'm going for a full merge with Debian open-iscsi (2.1.1-1) experimental now. I *think* its included already, if not I'll take this as well.

[Rafael David Tinoco (rafaeldtinoco)]

FTR:

https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1891374

Full 2.1.1. merge on-going.

[Dave Jones (waveform)]

@rafaeldtinoco Thanks for the heads-up; I'll close this as the merge is obviously preferable and yes, the commit I derived the patch from (https://github.com/open-iscsi/open-iscsi/commit/499a006a7d6bb154f9e1ab430e4c9e231ba6096a) is tagged under 2.1.1 so it should be included.