Location services work with location services off, 20.04

[NoBugs!]

* Impact

Disabling the location service in settings isn't reflection on traditional deb applications

* Test case

- Log in an Ubuntu desktop session
- install geoclue-2-demo
- go to gnome-control-center, privacy, location and ensure the service is disabled
- $ /usr/libexec/geoclue-2.0/demos/where-am-i

the script should return a permission error and not a location

* Regression potential

[racb] Users who are currently relying on a working location service despite having a setting disabling it will find that the location service will stop working because the setting will start to be honoured.

The change is in the client library, try a few applications, deb and snap or flatpak and make sure the status is correct respected

-----------------------------

Not sure if this is the right package, but in the privacy -> location settings, in 18.04 I had to have my application be approved by user to access location with Geoclue. Now it seems this is working without the location services "enabled"??

My application is repeater-START: https://sourceforge.net/projects/repeater-start/

Steps to see issue:
1) install Repeater-START and click the locate me button circle to the left. It goes to your rough location on map.

2) Go to settings, privacy, location, note that location is turned off!?

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: gnome-settings-daemon 3.36.1-0ubuntu1
ProcVersionSignature: Ubuntu 5.4.0-40.44-generic 5.4.44
Uname: Linux 5.4.0-40-generic x86_64
NonfreeKernelModules: wl
ApportVersion: 2.20.11-0ubuntu27.3
Architecture: amd64
CasperMD5CheckResult: skip
Date: Sat Aug 8 19:38:12 2020
InstallationDate: Installed on 2017-07-29 (1106 days ago)
InstallationMedia: Ubuntu 17.04 "Zesty Zapus" - Release amd64 (20170412)
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: gnome-settings-daemon
UpgradeStatus: Upgraded to focal on 2020-06-22 (47 days ago)

[Sebastien Bacher (seb128)]

Thank you for your bug report, that seems similar to what is discussed in https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/805 and a geoclue issue

[Danielle Foré (danrabbit)]

The upstream issue for this is located here: https://gitlab.freedesktop.org/geoclue/geoclue/-/issues/111

And it was addressed in this commit: https://gitlab.freedesktop.org/geoclue/geoclue/-/commit/d223fe19a6662c53601907b8f076631515c511c9

which was released in GeoClue 5.1.7 here: https://gitlab.freedesktop.org/geoclue/geoclue/-/releases/2.5.7

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Danielle Foré (danrabbit)]

Sorry, the version number is 2.5.7. Struggling to read a bit here. We're also tracking this issue downstream here: https://github.com/elementary/pantheon-agent-geoclue2/issues/41

[Olivier Tilloy (osomon)]

I'm marking this fixed as geoclue 2.5.7 is already in the development series (hirsute).
I have added the rls-gg-incoming and rls-hh-incoming tags to mark it as a candidate for a SRU to groovy (20.10) and focal (20.04). This will be reviewed at the next desktop team meeting.

[Danielle Foré (danrabbit)]

Thank you very much for adding the SRU to the desktop team's agenda!

[Sebastien Bacher (seb128)]

SRU uploaded to the focal queue now

[Robie Basak (racb)]

Hello NoBugs!, or anyone else affected,

Accepted geoclue-2.0 into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/geoclue-2.0/2.5.6-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[NoBugs! (luke32j)]

I upgraded my 20.04 with the proposed-updates, restarted, and I got an alert that I needed to accept location permissions upon hitting the lower left locate button on my app, initially. I open the privacy settings in location and my app is not listed??

However, location now works, at least every other time. I wonder if anyone else can run a similar test?
I see no applications have asked for location access, in privacy settings.

[Danielle Foré (danrabbit)]

I installed GeoClue 2.5.6-0ubuntu1.1 from proposed including the dev and demo packages. I cannot confirm that this fixes the issue as described in the test case above using the where-am-i demo and Pantheon's polkit agent

I then tried with GNOME Maps both from deb packaging and from Flatpak and both were able to access my location while location services were disabled

I also tried using the agent demo from geoclue-2-demo, and both where-am-i and GNOME maps were able to access location without permission while location services were marked disabled

[Danielle Foré (danrabbit)]

I can also confirm the comment from NoBugs! (luke32j) that no apps appear to have requested location access in privacy settings even though they have location access

[Sebastien Bacher (seb128)]

Alright, thanks for the testing. Sounds like the patch supposed to fix it doesn't work as intended there. I don't have more cycles to spent on investigating the issue more at the moment so I'm going to set it back to triaged and unassign myself, with some luck someone can help sorting it out.

[Iain Lane (laney)]

(sorry, just noticed I didn't assign this last week when I was supposed to)

[Łukasz Zemczak (sil2100)]

The version of geoclue-2.0 in the proposed pocket of Focal that was purported to fix this bug report has been removed because one or more bugs that were to be fixed by the upload have failed verification and been in this state for more than 10 days.

[Sebastien Bacher (seb128)]

There hasn't been more report about that and there is a new LTS out since, we are not likely to work on changing focal at this point