After "dcmanager fw-update-strategy apply", labels applied to one image show on all related subclouds

[Difu Hu]

Brief Description
-----------------
"system --os-region-name SystemController device-image-apply" to apply several labels to one image.
After "dcmanager fw-update-strategy apply", all these labels show on related subclouds.

Severity
--------
Minor

Steps to Reproduce
------------------
system --os-auth-url https://[fd01:12::2]:5001/v3 --os-region-name subcloud1 host-device-label-assign controller-0 0000:b2:00.0 subcloud1=29
system --os-auth-url https://[fd01:303::2]:5001/v3 --os-region-name subcloud3 host-device-label-assign controller-0 0000:b4:00.0 subcloud3=29
system --os-region-name SystemController device-image-upload 5gldpc_1x2x25g_20ww2.3_swap_ddr4_2xrefresh-signed-ssl-csk2.bin functional 8086 0b30 --bitstream-id 21
system --os-region-name SystemController device-image-apply 78fdbeca-b97d-4af7-9d20-e676bb873c87 subcloud1=29 subcloud3=29 nonsubcloud=xyz
dcmanager fw-update-strategy create
dcmanager fw-update-strategy apply

Expected Behavior
------------------
Update works on all subcloud.
(Not sure for label behavior)

Actual Behavior
----------------
Update works on all subcloud.
All these labels show in subclouds, which seems not friendly, especially if there are many labels.

Reproducibility
---------------
yes

System Configuration
--------------------
Lab-name: DC-3

Branch/Pull Time/Commit
-----------------------
2020-08-07_20-00-00

Last Pass
---------
2020-07-31_20-00-00

Timestamp/Logs
--------------
[sysadmin@controller-0 ~(keystone_admin)]$ system --os-region-name SystemController device-image-show 78fdbeca-b97d-4af7-9d20-e676bb873c87
+----------------+--------------------------------------------------------------------------+
| Property | Value |
+----------------+--------------------------------------------------------------------------+
| uuid | 78fdbeca-b97d-4af7-9d20-e676bb873c87 |
| bitstream_type | functional |
| pci_vendor | 8086 |
| pci_device | 0b30 |
| bitstream_id | 21 |
| key_signature | None |
| revoke_key_id | None |
| name | None |
| description | None |
| image_version | None |
| applied | True |
| applied_labels | [{u'subcloud1': u'29'}, {u'subcloud3': u'29'}, {u'nonsubcloud': u'xyz'}] |
+----------------+--------------------------------------------------------------------------+

[sysadmin@controller-0 ~(keystone_admin)]$ system --os-auth-url https://[fd01:12::2]:5001/v3 --os-region-name subcloud1 device-label-list
+--------------+------------------+-------------+-------------+
| hostname | PCI device name | label key | label value |
+--------------+------------------+-------------+-------------+
| | | subcloud3 | 29 |
| | | nonsubcloud | xyz |
| controller-0 | pci_0000_b2_00_0 | subcloud1 | 29 |
+--------------+------------------+-------------+-------------+
[sysadmin@controller-0 ~(keystone_admin)]$ system --os-auth-url https://[fd01:12::2]:5001/v3 --os-region-name subcloud1 device-image-show 78fdbeca-b97d-4af7-9d20-e676bb873c87
+----------------+--------------------------------------------------------------------------+
| Property | Value |
+----------------+--------------------------------------------------------------------------+
| uuid | 78fdbeca-b97d-4af7-9d20-e676bb873c87 |
| bitstream_type | functional |
| pci_vendor | 8086 |
| pci_device | 0b30 |
| bitstream_id | 21 |
| key_signature | None |
| revoke_key_id | None |
| name | None |
| description | None |
| image_version | None |
| applied | True |
| applied_labels | [{u'subcloud1': u'29'}, {u'subcloud3': u'29'}, {u'nonsubcloud': u'xyz'}] |
+----------------+--------------------------------------------------------------------------+

[sysadmin@controller-0 ~(keystone_admin)]$ system --os-auth-url https://[fd01:303::2]:5001/v3 --os-region-name subcloud3 device-label-list
+--------------+------------------+-------------+-------------+
| hostname | PCI device name | label key | label value |
+--------------+------------------+-------------+-------------+
| | | subcloud1 | 29 |
| | | nonsubcloud | xyz |
| controller-0 | pci_0000_b4_00_0 | subcloud3 | 29 |
+--------------+------------------+-------------+-------------+
[sysadmin@controller-0 ~(keystone_admin)]$ system --os-auth-url https://[fd01:303::2]:5001/v3 --os-region-name subcloud3 device-image-show 78fdbeca-b97d-4af7-9d20-e676bb873c87
+----------------+--------------------------------------------------------------------------+
| Property | Value |
+----------------+--------------------------------------------------------------------------+
| uuid | 78fdbeca-b97d-4af7-9d20-e676bb873c87 |
| bitstream_type | functional |
| pci_vendor | 8086 |
| pci_device | 0b30 |
| bitstream_id | 21 |
| key_signature | None |
| revoke_key_id | None |
| name | None |
| description | None |
| image_version | None |
| applied | True |
| applied_labels | [{u'subcloud3': u'29'}, {u'subcloud1': u'29'}, {u'nonsubcloud': u'xyz'}] |
+----------------+--------------------------------------------------------------------------+

Test Activity
-------------
Functional Testing

[Difu Hu (difuhu)]

log
https://files.starlingx.kube.cengn.ca/launchpad/1890918

[Al Bailey (albailey1974)]

The code explicitly applies with all the labels that are applied to that image in the system controller.
https://github.com/starlingx/distcloud/blob/master/distributedcloud/dcmanager/manager/states/firmware/importing_firmware.py#L149

[Ghada Khalil (gkhalil)]

Low priority - this is working as expected right now. TBD whether we would consider doing something different here.