OpenStack Compute (nova)

format_message() is specifica novaException is not should raise in generic exeptions

Bug #1890428 reported by Brin Zhang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Brin Zhang
Ussuri
Fix Released
Low
Stephen Finucane

Bug Description

In [1] we used format_message() to print the exception info, but the format_message() was specific for nova exception, we dont should do for that, just need to print exec is enough.

[1]https://review.opendev.org/#/c/631244/69/nova/compute/manager.py@2599

Brin Zhang (zhangbailin)
Changed in nova:
importance: Undecided → Low
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: nobody → Brin Zhang (zhangbailin)
status: New → In Progress
Brin Zhang (zhangbailin)
Changed in nova:
milestone: none → ussuri-rc1
milestone: ussuri-rc1 → none
no longer affects: nova (Ubuntu)
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: Brin Zhang (zhangbailin) → Stephen Finucane (stephenfinucane)
Brin Zhang (zhangbailin)
Changed in nova:
assignee: Stephen Finucane (stephenfinucane) → Brin Zhang (zhangbailin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/744280
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5d26fda5ea1efd14dd7b5bd9ea3f8debfb32b4c6
Submitter: Zuul
Branch: master

commit 5d26fda5ea1efd14dd7b5bd9ea3f8debfb32b4c6
Author: zhangbailin <email address hidden>
Date: Sat Aug 1 16:45:03 2020 +0800

    [Trivial] Remove wrong format_message() conversion

    This is a bug, follow up with the nova-cyborg-interaction patch,
    comment by sean-k-mooney [1].

    [1]https://review.opendev.org/#/c/631244/69/nova/compute/manager.py@2599

    Closes-Bug: #1890428

    Change-Id: I40bd9c0fa62c8087fa06af44b0b28dfe050fa1e6

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/746264

Revision history for this message
Brin Zhang (zhangbailin) wrote :

https://review.opendev.org/#/c/746264/1 fixed in Ussuri Release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/746464

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/ussuri)

Change abandoned by Brin Zhang (<email address hidden>) on branch: stable/ussuri
Review: https://review.opendev.org/746264
Reason: cherry-picked by https://review.opendev.org/#/c/746464/1

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ussuri)

Reviewed: https://review.opendev.org/746464
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=30ee639b6292b006bbbfe9843b17739c0b8441e7
Submitter: Zuul
Branch: stable/ussuri

commit 30ee639b6292b006bbbfe9843b17739c0b8441e7
Author: zhangbailin <email address hidden>
Date: Sat Aug 1 16:45:03 2020 +0800

    [Trivial] Remove wrong format_message() conversion

    This is a bug, follow up with the nova-cyborg-interaction patch,
    comment by sean-k-mooney [1].

    Conflicts:
      nova/compute/manager.py

    NOTE(stephenfin): Conflicts are due to change
    Ifc8fe3b8cc589d27e9d9f00122dffd7e6ed10b13 ("Remove unused function
    parameters") which is trivial cleanup but likely too invasive to
    backport.

    [1] https://review.opendev.org/#/c/631244/69/nova/compute/manager.py@2599

    Change-Id: I40bd9c0fa62c8087fa06af44b0b28dfe050fa1e6
    Closes-Bug: #1890428
    (cherry picked from commit 5d26fda5ea1efd14dd7b5bd9ea3f8debfb32b4c6)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.