Storwize: check_vdisk_fc_mappings method is not deleting the clone fc maps, if the fc status is in copying and autodelete is set to off.

[Girish_IBM]

when multiple clones and snapshots are created using common source volume, and deleting the source volume is not removing all the fcmaps involved in mapping with source volume.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/744664

[Girish_IBM (girishibm)]

Review link for check vdisk fcmap clean up: https://review.opendev.org/#/c/744664/

[Girish_IBM (girishibm)]

Duplicate defect for fcmap clean up in check_vdisk_fc_mappings, below is the defect details
https://bugs.launchpad.net/cinder/+bug/1890594

[Girish_IBM (girishibm)]

Usecase 1: Create 5 snap fcmaps from common source volume and 1 clone fcmap from snap volume.
usecase 2: Create 3 snap fcmaps from common source volume and 1 clone fcmap from snap volume.
usecase 3: Create 3 snap fcmaps from common source volume and 2 clone fcmap from snap volume.
Usecase 4: create 4 chain clone fcmaps, source for new clone fcmap should be target of already created clone fcmap.

[Girish_IBM (girishibm)]

-> In pretreatment_before_revert clone fcmaps are stopped using split attribute.
-> When the status of clone fcmap is 'copying',progress is 100% and clone fcmap has dependent fcmaps split should not be used with stopfcmap.
-> Fixed that issue with by not passing split attribute to stopfcmap.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 18.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 17.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 16.3.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/779141
Committed: https://opendev.org/openstack/cinder/commit/1d10e63bdf38fd174a2e367abc12e98bb415fae5
Submitter: "Zuul (22348)"
Branch: stable/train

commit 1d10e63bdf38fd174a2e367abc12e98bb415fae5
Author: GirishChilukuri <email address hidden>
Date: Tue Oct 6 19:09:34 2020 +0000

    [SVF]:Fix clone fcmap not being deleted in cleanup

    [Spectrum Virtualize Family] check_vdisk_fc_mappings is not deleting
    clone fc maps, if the flashcopy status is in copying autodelete is set
    to on and copy progress is 100%. when multiple clones and snapshots
    are created using common source volume, deleting the source volume
    is not removing all the fcmaps involved in mapping with source volume.

    This patch fixes the issue by removing the clone fcmap and then
    removing the snapshot fcmap when the source has more than one fcmap.

    Closes-Bug: #1890254

    Change-Id: I84629cde6d27d6889a30d7c13d99f57c660adde7
    (cherry picked from commit 3570a79a16127fd42216aa40b4f492e40533f0ed)
    (cherry picked from commit 6e592a8dd49a85f8658ffeeb8c95a9d39f1d8507)
    (cherry picked from commit c469c1294d5a09f926905414f505d6e84ebaf506)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 15.6.0 release.