Inconsistent Display of SMS Carrier Drop Down Options

[Erica Rohlfs]

Version 3.3, 3.4 +

This bug is related to https://bugs.launchpad.net/evergreen/+bug/1889913. The display of SMS Carriers within the various drop-down menus is inconsistent, specifically the display of the Carriers' regions.

The 2 most notable examples:

Patron registration Default SMS Carrier drop-down menu does not include the region within parenthesis.

When placing a hold, and selecting the mobile carrier, the drop-down does include the region within parenthesis.

Screen image of comparison attached.

[Garry Collum (gcollum)]

A proposed patch is here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1889916-SMS-Carrier-does-not-include-region-in-borrower-edit

[Jason Boyer (jboyer)]

Hi Garry, similar to bug 1809157 it may be best to also sort the carriers by name in addition to including the region.

[Garry Collum (gcollum)]

Thanks Jason,

Agreed. Here's a new patch that also includes sorting.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1889916-SMS-Carrier-does-not-include-region

[Josh Stompro (u-launchpad-stompro-org)]

Tested this on https://bugsquash.mobiusconsortium.org/eg/staff/ on 9/22/2021

1. Enabled SMS notice feature in library settings.
2. Logged out, logged in.
3. Edited a patron (https://bugsquash.mobiusconsortium.org/eg/staff/circ/patron/70/edit)
4. Confirm that the Carrier is sorted and has the region after the carrier name.
5. Seems to match the traditional catalog sms carrier drop down now.
6. When I tried to place a hold using the angular staff catalog, no carrier drop down was shown. So I couldn't confirm that it matches that. But that shouldn't hold this up.

I think this addresses the original bug report fully.

I have tested this code and consent to signing off on it with my name,
Josh Stompro and my email address, <email address hidden>.

Josh

[John Amundson (jamundson)]

Josh - Do you know if this patch is the cause of the empty SMS Carrier field you saw in the Angular Catalog?

When I view the Angular Place Hold screen on another testing server (festivus), the carrier dropdown populates for me.

See screenshot comparison. Festivus on left vs bugsquash on right.

[Galen Charlton (gmc)]

Pushed down to rel_3_9. Thanks, Garry and Josh!