Missing quotes in tripleo_common/inventories.py prevent host vars to be populated properly

[Cédric Jeanneret]

A term isn't quoted in the code, preventing the additional host vars to be present in the inventory.

This should be corrected at least down to train.

[Cédric Jeanneret (cjeanner)]

https://review.opendev.org/#/c/743990/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743990
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=e2613f0317721cf8231fe6a5a27f29f555b50a69
Submitter: Zuul
Branch: master

commit e2613f0317721cf8231fe6a5a27f29f555b50a69
Author: Cédric Jeanneret <email address hidden>
Date: Thu Jul 30 16:36:53 2020 +0200

    Correct the inventory generation

    The missing quotes didn't trigger anything since "vars" is representing
    the vars() method...
    Adding the missing quotes allows to actually get the injected host
    variables in the inventory, among them the well needed "container_cli"
    for the validations.

    This patch also makes a huge update in the different inline dict, in
    order to make them more human readable. This should help for further
    editions.

    Closes-Bug: #1889635
    Change-Id: I7418ea45d89dd0da7ac39193200f47563acab4cb

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/745730

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/745732

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/745732
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=a51595922721eec1e155b88310068d1f7b1aa5a8
Submitter: Zuul
Branch: stable/train

commit a51595922721eec1e155b88310068d1f7b1aa5a8
Author: Cédric Jeanneret <email address hidden>
Date: Thu Jul 30 16:36:53 2020 +0200

    Correct the inventory generation

    The missing quotes didn't trigger anything since "vars" is representing
    the vars() method...
    Adding the missing quotes allows to actually get the injected host
    variables in the inventory, among them the well needed "container_cli"
    for the validations.

    This patch also makes a huge update in the different inline dict, in
    order to make them more human readable. This should help for further
    editions.

    Closes-Bug: #1889635
    Change-Id: I7418ea45d89dd0da7ac39193200f47563acab4cb
    (cherry picked from commit e2613f0317721cf8231fe6a5a27f29f555b50a69)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/745730
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=8c46cbb0eff1fba2c80387508028a801f7191afe
Submitter: Zuul
Branch: stable/ussuri

commit 8c46cbb0eff1fba2c80387508028a801f7191afe
Author: Cédric Jeanneret <email address hidden>
Date: Thu Jul 30 16:36:53 2020 +0200

    Correct the inventory generation

    The missing quotes didn't trigger anything since "vars" is representing
    the vars() method...
    Adding the missing quotes allows to actually get the injected host
    variables in the inventory, among them the well needed "container_cli"
    for the validations.

    This patch also makes a huge update in the different inline dict, in
    order to make them more human readable. This should help for further
    editions.

    Closes-Bug: #1889635
    Change-Id: I7418ea45d89dd0da7ac39193200f47563acab4cb
    (cherry picked from commit e2613f0317721cf8231fe6a5a27f29f555b50a69)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 11.5.0 release.