kmail composer uses wrong name for ibm866 charset

[Sergei Ivanov]

Kmail composer understands the "ibm866" charset but uses "ibm 866" (with a space!) as its name in outgoing mail. This is incorrect, and other mail clients are confused by this space. I was hit by this when I received a mail with charset=ibm866, replied to it, and recipients could not read the reply because Kmail tried to use the same charset when replying but wrote 'charset="ibm 866"' in the header.

To reproduce:

In Kmail, go to Settings -> Composer -> Charset, try to add "ibm866" to the list. It adds "ibm 866" instead.

Or, alternatively:

Make sure the option "Keep original charset when replying ..." (in the same menu) is checked.
Get a mail with charset="ibm866" (for example, create a simple ascii mail and edit "Content-Type:" field by hand).
Reply to this mail and view the reply as plain text. It has

Content-Type: text/plain;
  charset="ibm 866"

The clients that cannot read this include (some versions of) SquirrelMail, MS Outlook Express, The Bat.

I am using Gutsy, kmail version is 4:3.5.7enterprise20070926-0ubuntu2. Output of kmail --version is:
Qt: 3.3.7
KDE: 3.5.8
KMail: 1.9.6 (enterprise 0.20070907.709405)

[Richard Birnie (rbirnie-deactivatedaccount)]

Do you still observe this bug in more recent versions of kmail?

I just tried to reproduce this in both hardy and intrepid both with kde4 and kmail 1.10.1 using these steps
In Kmail, go to Settings -> Composer -> Charset, try to add "ibm866" to the list.

In both cases the entry was added to the list as ibm866, no space. It's looks like this has been fixed upstream.

[Sergei Ivanov (svivanov)]

On Wednesday 24 September 2008, Richard Birnie wrote:
> Do you still observe this bug in more recent versions of kmail?

Yes I still observe it in hardy.

> I just tried to reproduce this in both hardy and intrepid both with kde4 and kmail 1.10.1

For some reason, the version I am using is older:

~$ kmail --version
Qt: 3.3.8b
KDE: 3.5.9
KMail: 1.9.9

The kmail package version (as shown by aptitude) is 4:3.5.9-0ubuntu3.

However aptitude does not show any upgradable packages.
Do I miss some repository to upgrade from?

[Richard Birnie (rbirnie-deactivatedaccount)]

On Fri, Sep 26, 2008 at 12:28 AM, Sergei Ivanov <email address hidden>wrote:

> On Wednesday 24 September 2008, Richard Birnie wrote:
> > Do you still observe this bug in more recent versions of kmail?
>
> Yes I still observe it in hardy.
>
> > I just tried to reproduce this in both hardy and intrepid both with
> kde4 and kmail 1.10.1
>
> For some reason, the version I am using is older:
>
> ~$ kmail --version
> Qt: 3.3.8b
> KDE: 3.5.9
> KMail: 1.9.9
>
> The kmail package version (as shown by aptitude) is 4:3.5.9-0ubuntu3.
>
> However aptitude does not show any upgradable packages.
> Do I miss some repository to upgrade from?
>

No you haven't missed an upgrade. I have both KDE3 and KDE4 installed on my
Hardy box. kmail 1.10.1 is from KDE4.1.1. This gives us more useful
information because it suggests the bug is restricted to KDE3. I'll try to
investigate this further.

>
> --
> kmail composer uses wrong name for ibm866 charset
> https://bugs.launchpad.net/bugs/188950
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[Richard Birnie (rbirnie-deactivatedaccount)]

I still haven't managed to reproduce this. KDE3.5.10 has now been released. Does this problem still occur for you?

[Sergei Ivanov (svivanov)]

On Wednesday 29 October 2008, Richard Birnie wrote:
> I still haven't managed to reproduce this. KDE3.5.10 has now been
> released. Does this problem still occur for you?
>

Yes, it still inserts a space when I add "ibm866" in Settings->Composer->Charset,
and it this space can occur in the outgoing mail.

I am pretty sure that this bug is in QT. I have libqt3-mt version 3.3.8-b-0ubuntu3
installed at the moment, you may have some better version.

Back then, I grepped the sources for "ibm 866" with a space and found an occurence
in some table within QT sources but nowhere in KDE. I even made a patch (see below)
and I think it worked then. Then I forgot about it, and then some apt-get upgrade
killed it (sigh)... Sorry for not reporting this fact until now.

--- qt-x11-free-3.3.8really3.3.7/src/codecs/qtextcodec.cpp.-space
+++ qt-x11-free-3.3.8really3.3.7/src/codecs/qtextcodec.cpp
@@ -1971,7 +1971,7 @@
         0x0E48, 0x0E49, 0x0E4A, 0x0E4B, 0x0E4C, 0x0E4D, 0x0E4E, 0x0E4F,
         0x0E50, 0x0E51, 0x0E52, 0x0E53, 0x0E54, 0x0E55, 0x0E56, 0x0E57,
         0x0E58, 0x0E59, 0x0E5A, 0x0E5B, 0xFFFD, 0xFFFD, 0xFFFD, 0xFFFD} },
- { "IBM 866", "IBM 866", 2086,
+ { "IBM866", "IBM 866", 2086,
       { 0x0410, 0x0411, 0x0412, 0x0413, 0x0414, 0x0415, 0x0416, 0x0417,
         0x0418, 0x0419, 0x041A, 0x041B, 0x041C, 0x041D, 0x041E, 0x041F,
         0x0420, 0x0421, 0x0422, 0x0423, 0x0424, 0x0425, 0x0426, 0x0427,

[Richard Birnie (rbirnie-deactivatedaccount)]

Thanks for the extra information. I think that gives us the final diagnosis. This is something that would need to be fixed upstream and backported. I've just discussed this with some other developers on irc and the consensus is that because the bug is fixed in KDE4 the qt devs are unlikely to be interested. The only thing I can really do is close this as fixed. Feel free to reopen if it can be reproduced in KDE4