undercloud update error with [tripleo-podman : Clean podman images]

[Emilien Macchi]

Reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1860640

Description of problem:
Performing a undercloud update from 16.0 to 16.1. After running the "openstack undercloud upgrade" command, the actual upgrade tasks run successfully, but the post-upgrade tasks fail at the following:

TASK [Purge Podman] *********************************************************************************************************************************************************
Sunday 26 July 2020 04:47:15 +0000 (0:00:00.187) 0:00:13.334 ***********

TASK [tripleo-podman : Clean podman images] *********************************************************************************************************************************
Sunday 26 July 2020 04:47:15 +0000 (0:00:00.193) 0:00:13.527 ***********
fatal: [ccsosp-undercloud]: FAILED! => {"changed": true, "cmd": ["podman", "image", "prune", "-a"], "delta": "0:00:00.064692", "end": "2020-07-26 04:47:15.471864", "msg": "non-zero return code", "rc": 125, "start": "2020-07-26 04:47:15.407172", "stderr": "Error: error reading input: EOF", "stderr_lines": ["Error: error reading input: EOF"], "stdout": "\nWARNING! This will remove all dangling images.\nAre you sure you want to continue? [y/N] ", "stdout_lines": ["", "WARNING! This will remove all dangling images.", "Are you sure you want to continue? [y/N] "]}

Version-Release number of selected component (if applicable):
tripleo-ansible-0.5.1-0.20200611113655.34b8fcc.el8ost.noarch

How reproducible:
Tried running "openstack undercloud upgrade" for the 16.0 to 16.1 undercloud update three times and it fails on the same task.

Steps to Reproduce:
1. Install 16.0 undercloud
2. Switch repos and container image details
3. Run "openstack undercloud upgrade"
4. "Running ansible upgrade tasks" sections completes successfully
5. "Running ansible post-upgrade tasks" fails at the [tripleo-podman : Clean podman images] step

Actual results:
"post-upgrade" tasks fail

Expected results:
Successful "post-upgrade" tasks

Additional info:
Before my fourth attempt, I modified tripleo-podman/tasks/tripleo_podman_purge.yml and added the -f option:

- name: Podman prune
  become: true
  block:
    - name: Clean podman images
      command: podman image prune -a -f

    - name: Clean podman volumes
      command: podman volume prune -f

On my fourth attempt, the "post-upgrade" ran to completion.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/743760

[Cédric Jeanneret (cjeanner)]

The real issue is a wrong podman version. Pretty sure you're with 1.9.3 instead of 1.6.4...

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743760
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=f9b89173307bd6e8495c757c098c3dda01f8c822
Submitter: Zuul
Branch: master

commit f9b89173307bd6e8495c757c098c3dda01f8c822
Author: Emilien Macchi <email address hidden>
Date: Wed Jul 29 09:37:38 2020 -0400

    tripleo_podman_purge: try to use -f when pruning images

    Recent version of podman requires yes/no when pruning images, except if
    -f is given as an argument.

    Let's first try the new way, and fallback on the old method.

    Change-Id: Ie2a70d4ec40c2a2142b0857822edd5122b63c941
    Closes-Bug: #1889418

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/743826

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/743827

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743826
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=0bd8e5b3971db3aff5c7ccce41d46c0adb727fea
Submitter: Zuul
Branch: stable/ussuri

commit 0bd8e5b3971db3aff5c7ccce41d46c0adb727fea
Author: Emilien Macchi <email address hidden>
Date: Wed Jul 29 09:37:38 2020 -0400

    tripleo_podman_purge: try to use -f when pruning images

    Recent version of podman requires yes/no when pruning images, except if
    -f is given as an argument.

    Let's first try the new way, and fallback on the old method.

    Change-Id: Ie2a70d4ec40c2a2142b0857822edd5122b63c941
    Closes-Bug: #1889418
    (cherry picked from commit f9b89173307bd6e8495c757c098c3dda01f8c822)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743827
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=4826cb7a653a469bc486deab90d065be91dee513
Submitter: Zuul
Branch: stable/train

commit 4826cb7a653a469bc486deab90d065be91dee513
Author: Emilien Macchi <email address hidden>
Date: Wed Jul 29 09:37:38 2020 -0400

    tripleo_podman_purge: try to use -f when pruning images

    Recent version of podman requires yes/no when pruning images, except if
    -f is given as an argument.

    Let's first try the new way, and fallback on the old method.

    Change-Id: Ie2a70d4ec40c2a2142b0857822edd5122b63c941
    Closes-Bug: #1889418
    (cherry picked from commit f9b89173307bd6e8495c757c098c3dda01f8c822)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 0.6.0 release.