[FT] TestMaintenance.test_port failing

[Rodolfo Alonso]

FT failing: neutron.tests.functional.plugins.ml2.drivers.ovn.mech_driver.ovsdb.test_maintenance.TestMaintenance .test_port

Error: the port is still present in the system after executing the "check_for_inconsistencies" method.
ft1.6: neutron.tests.functional.plugins.ml2.drivers.ovn.mech_driver.ovsdb.test_maintenance.TestMaintenance.test_porttesttools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 182, in func
    return f(self, *args, **kwargs)
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py", line 340, in test_port
    self.assertIsNone(self._find_port_row_by_name(new_obj_name))
  File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/lib/python3.6/site-packages/testtools/testcase.py", line 430, in assertIsNone
    self.assertThat(observed, matcher, message)
  File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/lib/python3.6/site-packages/testtools/testcase.py", line 502, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: <ovs.db.idl.Row object at 0x7fab50e40940> is not None

Log: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_956/729931/1/check/neutron-functional-with-uwsgi/9562cda/testr_results.html

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/742868

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Same error reproduced in https://review.opendev.org/742868

https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_8a9/742868/1/check/neutron-functional/8a92c04/testr_results.html

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Catched: when the network_id is built, the method to remove "neutron-" is not correct [1]. This should be "replace" instead of "strip".

[1]https://github.com/openstack/neutron/blob/805b10561e803188dd38a2ee6995c9e6e9d71914/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py#L573

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/743577

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.opendev.org/742868
Reason: Patch https://review.opendev.org/#/c/743577/ is working fine

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743577
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fc5a8ee1b893a85b7cb3d9fac010c28714e9c50e
Submitter: Zuul
Branch: master

commit fc5a8ee1b893a85b7cb3d9fac010c28714e9c50e
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jul 28 15:43:45 2020 +0000

    Use "replace" to remove a section of a string

    From "strip" documentation:
      Return a copy of the string with leading whitespace removed.
      If chars is given and not None, remove characters in chars instead.

    Change-Id: Ia1bf0a98b327b4deaa4ff87da79b70d27314434a
    Closes-Bug: #1888828

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/743925

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743925
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8200c68f68759738547af162a2be64bdeaa85551
Submitter: Zuul
Branch: stable/ussuri

commit 8200c68f68759738547af162a2be64bdeaa85551
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jul 28 15:43:45 2020 +0000

    Use "replace" to remove a section of a string

    From "strip" documentation:
      Return a copy of the string with leading whitespace removed.
      If chars is given and not None, remove characters in chars instead.

    Change-Id: Ia1bf0a98b327b4deaa4ff87da79b70d27314434a
    Closes-Bug: #1888828
    (cherry picked from commit fc5a8ee1b893a85b7cb3d9fac010c28714e9c50e)