config that isn't used

Bug #1888635 reported by John A Meinel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
charm-k8s-jenkins-agent
Fix Released
Medium
Unassigned

Bug Description

As of fc0869932f1bb06d3353b440bb1d082a63484a49
the charm has a config.yaml with:
options:
  image:
    type: string
    default: "jenkins-agent-operator"
    description: "The docker image to install. Required. Defaults to jenkins-agent-operator from rocks.canonical.com"
  tools:
    type: string
    default: git gcc make bzr
    description: Tooling to deploy on jenkins agent node
  labels:
    type: string
    description: Jenkins labels to associate with jenkins agent node
    default: ""
  jenkins_master_url:
    type: string
    default: ""
    description: |
      Configure the agent to use an explicit jenkins master instead of using
      the jenkins-agent relation. This allows for the agent and master to
      be deployed in different environments.
  jenkins_agent_name:
    type: string
    default: ""
    description: |
      Jenkins agent name that will be seen on the jenkins master.
      Will default to the hostname of the container.
  jenkins_api_token:
    type: string
    default: ""
    description: "Jenkins API token used to join the master"
  jenkins_user:
    type: string
    default: "admin"
    description: "Jenkins user to download agent.jar from master"

However both tools and labels appear to be unused.
It is unclear whether these are carryover from a different charm, and should be pruned, or whether it is intended as desired future use.

Is jenkins_master_url still desirable now that Juju supports cross model relations?

Tom Haddon (mthaddon)
Changed in charm-k8s-jenkins-agent:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Tom Haddon (mthaddon) wrote :

This has been addressed.

Changed in charm-k8s-jenkins-agent:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.