tripleo

puppet-tripleo jobs fail in ussuri in puppet linter checks

Bug #1887830 reported by Damien Ciabrini
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
Damien Ciabrini
tripleo xena-3

Bug Description

Puppet lint option "relative_classname_inclusion" was re-enabled recently [1], and this seems to be causing error in puppet-tripleo jobs in at least master and ussuri [2].

A fix in puppet-tripleo has been merged upstream recently to fix the errors seen on master [3]. We probably need to backport it to ussuri to get rid of the same lint errors.

[1] https://review.opendev.org/#/c/740023/
[2] https://review.opendev.org/#/c/737996/
[3] https://review.opendev.org/#/c/741075/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/741501

Revision history for this message
Takashi Kajinami (kajinamit) wrote :

IIUC the problem here is that we always use master branch of puppet-openstack_spec_helper .
I submitted a patch[1] so that we use stable/ussuri branch instead, and I think this should fix this problem.
 [1] https://review.opendev.org/#/c/741571/

I'll submit the same for old branches once I confirmed it.

Revision history for this message
Damien Ciabrini (dciabrin) wrote :

Ack, thanks Takashi.
Do you reckon I should abandon https://review.opendev.org/741501 then?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-tripleo (stable/ussuri)

Change abandoned by Damien Ciabrini (<email address hidden>) on branch: stable/ussuri
Review: https://review.opendev.org/741501
Reason: Abandonned, https://review.opendev.org/#/c/741571/ fixed the problem

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-tripleo (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/742671

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-tripleo (stable/train)

Change abandoned by Damien Ciabrini (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/742671
Reason: Thanks Takashi, abandoning in favor of https://review.opendev.org/#/c/741572/

Emilien Macchi (emilienm)
Changed in tripleo:
milestone: victoria-1 → victoria-3
Marios Andreou (marios-b)
Changed in tripleo:
milestone: victoria-3 → wallaby-1
Marios Andreou (marios-b)
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
Marios Andreou (marios-b)
Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Marios Andreou (marios-b)
Changed in tripleo:
milestone: wallaby-3 → wallaby-rc1
Marios Andreou (marios-b)
Changed in tripleo:
milestone: wallaby-rc1 → xena-1
Marios Andreou (marios-b)
Changed in tripleo:
milestone: xena-1 → xena-2
Marios Andreou (marios-b)
Changed in tripleo:
milestone: xena-2 → xena-3
Revision history for this message
Takashi Kajinami (kajinamit) wrote :

This was already fixed by https://review.opendev.org/c/openstack/puppet-tripleo/+/741571

Changed in tripleo:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.