Add machine does not show all supported options

[Lee Trager]

I was helping a customer setup MAAS and I realized that a number of options available on the API when adding a new machine are missing from the UI. Options that are missing include whether commissioning runs, what custom commissioning scripts run, and whether the BMC is configured. I believe these were omitted due to space, I'm creating this bug to revisit that decision since we are adding collapsible options to deploying.

Missing options:

 :param commission: Optional. Request
the newly created machine to be created with status set to
COMMISSIONING. Machines will wait for COMMISSIONING results and not
time out.
:type commission: Boolean

:param enable_ssh: Optional. Whether to enable SSH for
the commissioning environment using the user's SSH key(s). '1' == True,
'0' == False.
:type enable_ssh: Int

 :param skip_bmc_config: Optional. Whether to skip
re-configuration of the BMC for IPMI based machines. '1' == True, '0'
== False.
:type skip_bmc_config: Int

 :param commissioning_scripts: Optional. A comma
seperated list of commissioning script names and tags to be run. By
default all custom commissioning scripts are run. Built-in
commissioning scripts always run. Selecting 'update_firmware' or
'configure_hba' will run firmware updates or configure HBA's on
matching machines.
:type commissioning_scripts: String

 :param testing_scripts: Optional. A comma seperated
list of testing script names and tags to be run. By default all tests
tagged 'commissioning' will be run. Set to 'none' to disable running
tests.
:type testing_scripts: String

 :param description: Optional. A optional description.
:type description: String

[Bill Wear (billwear)]

I can verify that these options are indeed part of the CLI, and are indeed missing from the UI when adding a machine. Triaging.

[Amy Pattanasethanon (amylily)]

Do I need to set any default values in the UI for any of these fields?

[Lee Trager (ltrager)]

commission - Default to true

enable_ssh - Default to false

skip_bmc_config - Default to false

commissioning_scripts - If "commission" is false then this field should be disabled. If "commission" is true then all commissioning scripts should be selected unless they are tagged "noauto", just like the commissioning form does now.

testing_scripts - If "commission" is false then this field should be disabled. If "commission" is true then any testing script tagged "commissioning", just like the commissioning/testing form does now.

description - Empty field is fine for the default.

[Thorsten Merten (thorsten-merten)]

Designs have been created here: https://github.com/canonical/maas-ui/issues/1570
Bug was tracked here but is now being tracked in Launchpad: https://github.com/canonical/maas-ui/issues/1884

[Thorsten Merten (thorsten-merten)]

Need to double check what has been fixed already and might need UX work as well.