AttributeError: 'NoneType' object has no attribute 'set_release' (Upgrade Pike=>Queens)

[Jose Guedez]

Charm release: 297 / 20.05
Series: Xenial
Upgrade: Pike => Queens

Steps (from https://docs.openstack.org/project-deploy-guide/charm-deployment-guide/latest/app-upgrade-openstack.html#openstack-upgrades)

$ juju config glance action-managed-upgrade=true
$ juju config glance openstack-origin=cloud:xenial-queens
$ juju run-action --wait glance/0 openstack-upgrade # leader
$ juju run-action --wait glance/2 openstack-upgrade
$ juju run-action --wait glance/1 openstack-upgrade

The actions fail with the following stacktrace:

    outcome: upgrade failed, see traceback.
    traceback: |
      Traceback (most recent call last):
        File "/var/lib/juju/agents/unit-glance-1/charm/charmhelpers/contrib/openstack/utils.py", line 1382, in do_action_openstack_upgrade
          upgrade_callback(configs=configs)
        File "/var/lib/juju/agents/unit-glance-1/charm/hooks/glance_utils.py", line 368, in do_openstack_upgrade
          configs.set_release(openstack_release=new_os_rel)
      AttributeError: 'NoneType' object has no attribute 'set_release'
  status: failed

[Felipe Reyes (freyes)]

I'm seeing this when upgrading from Rocky to Stein using glance-298 (20.08 relese).

[Felipe Reyes (freyes)]

This regression was produced due to this commit http://github.com/openstack/charm-glance/commit/eb47ec1147336209ba78b918660bf1dbae240867 most likely.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/748019

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/20.08
Review: https://review.opendev.org/748118

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748019
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=d3bcd92616a23f04e6fce6a804045db6310ebb8a
Submitter: Zuul
Branch: master

commit d3bcd92616a23f04e6fce6a804045db6310ebb8a
Author: Felipe Reyes <email address hidden>
Date: Tue Aug 25 15:34:22 2020 -0400

    Use register_configs() in openstack-upgrade action

    CONFIGS global variable is no longer populated at load time instead is
    expected to use register_configs() function as pause/resume actions do.

    Change-Id: Id2504b40e09220c6cb6bb878727ffa181263e3f1
    Closes-Bug: #1887483
    Related-Bug: #1879537

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748118
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=5c5487ecc0737a91353d2d3e42472ed02240a58b
Submitter: Zuul
Branch: stable/20.08

commit 5c5487ecc0737a91353d2d3e42472ed02240a58b
Author: Felipe Reyes <email address hidden>
Date: Tue Aug 25 15:34:22 2020 -0400

    Use register_configs() in openstack-upgrade action

    CONFIGS global variable is no longer populated at load time instead is
    expected to use register_configs() function as pause/resume actions do.

    Change-Id: Id2504b40e09220c6cb6bb878727ffa181263e3f1
    Closes-Bug: #1887483
    Related-Bug: #1879537