Clear shelf_expire_time when hold checkin goes in transit

[Ryan Eby]

Evergreen 3.3.5 (code is still same in HEAD)
OpenSRF 3.2.0
PostgreSQL 10

Steps to reproduce:

1. Have an item available on the hold shelf
2. Have another hold at the same location
3. Check in the item with Capture Local Holds as Transits

The item will go in transit to the same location. The current_shelf_lib and shelf_time will be cleared but the shelf_expire_time will be left. I'm not sure if this is expected behaviour.

There may be two problems here though I haven't checked if fixed in newer version. I think if the item is checked in without the modifier it would be kicked back to the holdshelf if the hold wasn't cleared. In this case it goes In Transit and things are partially cleared out.

We had some situations where things were checked in directly from the hold shelf in this mode. It was noticed as we had some reports that only looked at cancel_time, capture_time, shelf_expire_time and fulfillment_time.

We've tweaked the reports to look at more fields but if this is meant to clear 'shelf-iness' then it should probably also do a clear_shelf_expire_time.

Code is here: https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm;h=d99d5259c4c8e7be5da3a51ee19df88f6dc2b672;hb=HEAD#l3148