tripleo

Undercloud minion failing validation ERROR: Heat Engine host count is 1 or less.

Bug #1886914 reported by Sandeep Yadav
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Alex Schultz
tripleo victoria-3 "tripleo victoria"

Bug Description

Undercloud minion job is failing for master branch with validation ERROR :-

~~~
2020-07-09 04:17:30.993363 | primary | TASK [validate-minion : Execute the simple minion validation] ******************
2020-07-09 04:17:30.993383 | primary | Thursday 09 July 2020 04:17:30 +0000 (0:00:02.014) 0:51:42.505 *********
2020-07-09 04:17:49.691563 | primary | fatal: [undercloud]: FAILED! => {
2020-07-09 04:17:49.691623 | primary | "changed": false,
2020-07-09 04:17:49.691643 | primary | "cmd": "set -o pipefail && /home/zuul/workspace/.quickstart/validate_minion_simple.sh | tee validate_minion_simple.log\n",
2020-07-09 04:17:49.691659 | primary | "delta": "0:00:18.236039",
2020-07-09 04:17:49.691710 | primary | "end": "2020-07-09 04:17:49.666266",
2020-07-09 04:17:49.691734 | primary | "rc": 1,
2020-07-09 04:17:49.691750 | primary | "start": "2020-07-09 04:17:31.430227"
2020-07-09 04:17:49.691765 | primary | }
2020-07-09 04:17:49.691780 | primary |
2020-07-09 04:17:49.691795 | primary | STDOUT:
2020-07-09 04:17:49.691820 | primary |
2020-07-09 04:17:49.691836 | primary | +------------------------+-------------+--------------------------------------+------------------------+--------+----------------------------+--------+
2020-07-09 04:17:49.691853 | primary | | Hostname | Binary | Engine ID | Host | Topic | Updated At | Status |
2020-07-09 04:17:49.691869 | primary | +------------------------+-------------+--------------------------------------+------------------------+--------+----------------------------+--------+
2020-07-09 04:17:49.691885 | primary | | undercloud.localdomain | heat-engine | 65d10d64-2b05-4147-ba39-7b1ae3514794 | undercloud.localdomain | engine | 2020-07-09T04:16:35.000000 | up |
2020-07-09 04:17:49.691900 | primary | | undercloud.localdomain | heat-engine | 1a3fc464-aefd-4c98-8124-af43af5f11d8 | undercloud.localdomain | engine | 2020-07-09T04:16:35.000000 | up |
2020-07-09 04:17:49.691916 | primary | | undercloud.localdomain | heat-engine | 72c7910c-cf62-490f-a3ca-1e6e785df813 | undercloud.localdomain | engine | 2020-07-09T04:16:35.000000 | up |
2020-07-09 04:17:49.691931 | primary | | undercloud.localdomain | heat-engine | 15ae929e-4954-4d95-a58e-6511687e7c73 | undercloud.localdomain | engine | 2020-07-09T04:16:35.000000 | up |
2020-07-09 04:17:49.691946 | primary | +------------------------+-------------+--------------------------------------+------------------------+--------+----------------------------+--------+
2020-07-09 04:17:49.691962 | primary | ERROR: Heat Engine host count is 1 or less.
2020-07-09 04:17:49.691977 | primary | +------------------------+-----------------+-------+
2020-07-09 04:17:49.691992 | primary | | Hostname | Conductor Group | Alive |
2020-07-09 04:17:49.692007 | primary | +------------------------+-----------------+-------+
2020-07-09 04:17:49.692022 | primary | | undercloud.localdomain | | True |
2020-07-09 04:17:49.692036 | primary | +------------------------+-----------------+-------+
2020-07-09 04:17:49.692051 | primary | ERROR: Ironic Conductor host count is 1 or less.
2020-07-09 04:17:49.692065 | primary |
2020-07-09 04:17:49.692079 | primary |
2020-07-09 04:17:49.692094 | primary | STDERR:
2020-07-09 04:17:49.692108 | primary |
2020-07-09 04:17:49.692122 | primary | + VALIDATE_HEAT_ENGINE=True
2020-07-09 04:17:49.692137 | primary | + VALIDATE_IRONIC_CONDUCTOR=True
2020-07-09 04:17:49.692151 | primary | + RC=0
2020-07-09 04:17:49.692171 | primary | + set +x
2020-07-09 04:17:49.692186 | primary | + [[ true == \t\r\u\e ]]
2020-07-09 04:17:49.692201 | primary | + openstack orchestration service list
2020-07-09 04:17:49.692215 | primary | ++ openstack orchestration service list -c Host -f value
2020-07-09 04:17:49.692230 | primary | ++ sort
2020-07-09 04:17:49.692244 | primary | ++ uniq
2020-07-09 04:17:49.692259 | primary | ++ wc -l
2020-07-09 04:17:49.692273 | primary | + HOST_COUNT=1
2020-07-09 04:17:49.692288 | primary | + '[' 1 -le 1 ']'
2020-07-09 04:17:49.692302 | primary | + echo 'ERROR: Heat Engine host count is 1 or less.'
2020-07-09 04:17:49.692316 | primary | + RC=1
2020-07-09 04:17:49.692331 | primary | ++ openstack orchestration service list -c Status -f value
2020-07-09 04:17:49.692345 | primary | ++ grep -v up
2020-07-09 04:17:49.692360 | primary | ++ wc -l
2020-07-09 04:17:49.692374 | primary | + DOWN_STATUS=0
2020-07-09 04:17:49.692389 | primary | + '[' 0 -ge 1 ']'
2020-07-09 04:17:49.692403 | primary | + [[ true == \t\r\u\e ]]
2020-07-09 04:17:49.692417 | primary | + openstack baremetal conductor list
2020-07-09 04:17:49.692431 | primary | ++ openstack baremetal conductor list -c Hostname -f value
2020-07-09 04:17:49.692445 | primary | ++ sort
2020-07-09 04:17:49.692460 | primary | ++ uniq
2020-07-09 04:17:49.692474 | primary | ++ wc -l
2020-07-09 04:17:49.692488 | primary | + HOST_COUNT=1
2020-07-09 04:17:49.692502 | primary | + '[' 1 -le 1 ']'
2020-07-09 04:17:49.692516 | primary | + echo 'ERROR: Ironic Conductor host count is 1 or less.'
2020-07-09 04:17:49.692530 | primary | + RC=1
2020-07-09 04:17:49.692545 | primary | ++ openstack baremetal conductor list -c Alive -f value
2020-07-09 04:17:49.692559 | primary | ++ grep -v True
2020-07-09 04:17:49.692579 | primary | ++ wc -l
2020-07-09 04:17:49.692595 | primary | + DOWN_STATUS=0
2020-07-09 04:17:49.692609 | primary | + '[' 0 -ge 1 ']'
2020-07-09 04:17:49.692629 | primary | + exit 1
2020-07-09 04:17:49.692645 | primary |
2020-07-09 04:17:49.692660 | primary |
2020-07-09 04:17:49.692674 | primary | MSG:
2020-07-09 04:17:49.692717 | primary |
2020-07-09 04:17:49.692734 | primary | non-zero return code
2020-07-09 04:17:49.695032 | primary |
2020-07-09 04:17:49.695092 | primary | PLAY RECAP *********************************************************************
2020-07-09 04:17:49.695113 | primary | 127.0.0.2 : ok=1 changed=0 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
2020-07-09 04:17:49.695129 | primary | subnode-1 : ok=74 changed=29 unreachable=0 failed=0 skipped=52 rescued=0 ignored=0
2020-07-09 04:17:49.695153 | primary | undercloud : ok=108 changed=50 unreachable=0 failed=1 skipped=129 rescued=0 ignored=0

~~~

Log links:-

https://16a586043fd88ddd8ac7-0aa6565d1e0c06a8a7c8c1f2b9ada9fc.ssl.cf5.rackcdn.com/724734/22/check/tripleo-ci-centos-8-containers-undercloud-minion/3fe43e7/job-output.txt

https://8ede074d110a1a4ac014-5061d1dd61c75bd0e8246a27130264c7.ssl.cf2.rackcdn.com/734649/16/check/tripleo-ci-centos-8-containers-undercloud-minion/a8e574c/job-output.txt

https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d31/739172/2/check/tripleo-ci-centos-8-containers-undercloud-minion/d31c7be/job-output.txt

Failure started on this job ~14:00 UTC , 08th July

https://zuul.openstack.org/builds?job_name=tripleo-ci-centos-8-containers-undercloud-minion&branch=master

Revision history for this message
Sandeep Yadav (sandeepyadav93) wrote :
Download full text (4.8 KiB)

Minion deployment failed because if failed to pull containers:-

https://16a586043fd88ddd8ac7-0aa6565d1e0c06a8a7c8c1f2b9ada9fc.ssl.cf5.rackcdn.com/724734/22/check/tripleo-ci-centos-8-containers-undercloud-minion/3fe43e7/logs/subnode-1/home/zuul/minion_install.log

~~~
2020-07-09 04:17:21.069 40274 ERROR tripleoclient.utils.utils [ ] Ansible execution failed. playbook: deploy_steps_playbook.yaml, Run Status: failed, Return Code: 2
2020-07-09 04:17:22.021 40274 WARNING tripleoclient.v1.tripleo_deploy.Deploy [ ] Not cleaning working directory /home/zuul/tripleo-heat-installer-templates
2020-07-09 04:17:22.055 40274 WARNING tripleoclient.v1.tripleo_deploy.Deploy [ ] Not cleaning ansible directory /home/zuul/minion-ansible-82pwk13f
2020-07-09 04:17:22.083 40274 WARNING tripleoclient.v1.tripleo_deploy.Deploy [ ] Install artifact is located at /home/zuul/minion-install-20200709041721.tar.bzip2
2020-07-09 04:17:22.084 40274 ERROR tripleoclient.v1.tripleo_deploy.Deploy [ ]
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Deployment Failed!

ERROR: Heat log files: /var/log/heat-launcher/undercloud_deploy-3w0p4527

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

2020-07-09 04:17:22.085 40274 ERROR openstack [ ] Deployment failed.
2020-07-09 04:17:22.290 40218 ERROR tripleoclient.v1.undercloud_minion.InstallUndercloudMinion [ ]
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

An error has occured while deploying the Undercloud Minion

See the previous output for details about what went wrong.

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

2020-07-09 04:17:22.291 40218 ERROR tripleoclient.v1.undercloud_minion.InstallUndercloudMinion [ ] Command '['sudo', '--preserve-env', 'openstack', 'tripleo', 'deploy', '--standalone', '--standalone-role', 'UndercloudMinion', '--stack', 'minion', '-r', '/usr/share/openstack-tripleo-heat-templates/roles/UndercloudMinion.yaml', '--local-ip=192.168.24.4/24', '--templates=/usr/share/openstack-tripleo-heat-templates', '--networks-file=network_data_undercloud.yaml', '-e', '/home/zuul/tripleo-config-generated-env-files/tripleo-undercloud-base.yaml', '--heat-native', '-e', '/usr/share/openstack-tripleo-heat-templates/environments/undercloud/undercloud-minion.yaml', '-e', '/usr/share/openstack-tripleo-heat-templates/environments/use-dns-for-vips.yaml', '-e', '/usr/share/openstack-tripleo-heat-templates/environments/podman.yaml', '-e', '/home/zuul/containers-prepare-parameter.yaml', '-e', '/usr/share/openstack-tripleo-heat-templates/environments/services/heat-engine.yaml', '-e', '/usr/share/openstack-tripleo-heat-templates/environments/services/ironic-conductor.yaml', '--deployment-user', 'zuul', '--output-dir=/home/zuul', '-e', '/home/zuul/tripleo-config-generated-env-files/minion_parameters.yaml', '--log-file=/home/zuul/minion_install.log', '-e', '/usr/share/openstack-tripleo-heat-templates/minion-stack-vstate-dropin.yaml']' returned non-zero exit status 1.
~~~

https://16a586043fd88ddd8ac7-0aa6565d1e0c06a8a7c8c1f2b9ada9fc.ssl.cf5.rackcdn.com/724734/22/check/tripleo-ci-centos-8-containers-undercloud-minion/3fe43e7/logs/subnode-1/home/zuul/undercloud_minion_install.log
...

Read more...

Revision history for this message
Sandeep Yadav (sandeepyadav93) wrote :
Download full text (3.3 KiB)

Investigation result:-

* Minion pulls container from undercloud.
* Undercloud was previously uploading containers in its registry with tags that also have modify_append_tag suffix like "-updated-20200709032646"
* In the failed jobs undercloud is uploading container without modify_append_tag suffix.

Minion is trying to pull container with tag (which is suffixed with modify_append_tag) but because that tag container don't exists - minion failed to pull containers from undercloud.

expected:-
=========

e961461fc3de7c29860ddacfcf697aaf-updated-20200709032646"

~~~
2020-07-09 04:17:19.547221 | bc764e20-0952-652d-4f3e-0000000006d8 | FATAL | Pre-fetch all the containers | minion | item=192.168.24.1:8787/tripleomaster/centos-binary-heat-engine:e961461fc3de7c29860ddacfcf697aaf-updated-20200709032646
~~~

Actual which undercloud is pushing now:-
======================================

e961461fc3de7c29860ddacfcf697aaf

Good job:-

https://73c3fc2c634b9a95041f-b66311f00e65e72370f624798f3cdac4.ssl.cf1.rackcdn.com/739863/1/gate/tripleo-ci-centos-8-containers-undercloud-minion/6a3a719/logs/undercloud/var/log/extra/podman/podman_allinfo.log

~~~
+ podman images
REPOSITORY TAG IMAGE ID CREATED SIZE
192.168.24.1:8787/tripleomaster/centos-binary-iscsid 0a66a7cdb816ac8940c9ab32130babe7-updated-20200708125801 dedf259390fd 34 minutes ago 449 MB
192.168.24.1:8787/tripleomaster/centos-binary-neutron-server 0a66a7cdb816ac8940c9ab32130babe7-updated-20200708125801 7db3da394906 34 minutes ago 1.02 GB
192.168.24.1:8787/tripleomaster/centos-binary-swift-account 0a66a7cdb816ac8940c9ab32130babe7-updated-20200708125801 8910460e8390 34 minutes ago 760 MB
192.168.24.1:8787/tripleomaster/centos-binary-swift-container 0a66a7cdb816ac8940c9ab32130babe7-updated-20200708125801 03896ed30a5d 34 minutes ago 760 MB
192.168.24.1:8787/tripleomaster/centos-binary-keystone 0a66a7cdb816ac8940c9ab32130babe7-updated-20200708125801 0768b3f4c2f5 34 minutes ago 805 MB
192.168.24.1:8787/tripleomaster/centos-binary-cron 0a66a7cdb816ac8940c9ab32130babe7-updated-20200708125801 92cec8dec81e 35 minutes ago 441 MB
~~~

Current affected job:-

https://16a586043fd88ddd8ac7-0aa6565d1e0c06a8a7c8c1f2b9ada9fc.ssl.cf5.rackcdn.com/724734/22/check/tripleo-ci-centos-8-containers-undercloud-minion/3fe43e7/logs/undercloud/var/log/extra/podman/podman_allinfo.log
~~~
+ podman images
REPOSITORY TAG IMAGE ID CREATED SIZE
192.168.24.1:8787/tripleomaster/centos-binary-heat-api e961461fc3de7c29860ddacfcf697aaf 8749c2baf2b6 17 hours ago 735 MB
192.168.24.1:8787/tripleomaster/centos-binary-heat-engine e961461fc3de7c29860ddacfcf697aaf 5e8f7551788f 17 hours ago 735 MB
192.168.24.1:8787/tripleomaster/centos-binary-neutron-l3-agent e961461fc3de7c29860ddacfcf697aaf 49394c6d04d6 17 hour...

Read more...

Revision history for this message
Emilien Macchi (emilienm) wrote :

The other issue is that the minion installed reported a failure so the validation should not have been run:

https://16a586043fd88ddd8ac7-0aa6565d1e0c06a8a7c8c1f2b9ada9fc.ssl.cf5.rackcdn.com/724734/22/check/tripleo-ci-centos-8-containers-undercloud-minion/3fe43e7/logs/subnode-1/home/zuul/undercloud_minion_install.log

Revision history for this message
Emilien Macchi (emilienm) wrote :

tripleoclient reported a failure:

https://16a586043fd88ddd8ac7-0aa6565d1e0c06a8a7c8c1f2b9ada9fc.ssl.cf5.rackcdn.com/724734/22/check/tripleo-ci-centos-8-containers-undercloud-minion/3fe43e7/logs/subnode-1/home/zuul/minion_install.log

and Ansible doesn't catch that failure.

Revision history for this message
Emilien Macchi (emilienm) wrote :

The container issue is because yum_update playbook didn't run in tripleo container image prepare, so the -updated images were not created.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/740277

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.opendev.org/740280

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.opendev.org/740277
Reason: not related, not needed

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.opendev.org/740280
Reason: not related, not needed

Revision history for this message
Emilien Macchi (emilienm) wrote :

The issue is the following:

Yesterday was pushed new container images that don't use Kolla.
The problem is that these new images don't have the LABEL "kolla_version" (see https://opendev.org/openstack/kolla/src/branch/master/docker/base/Dockerfile.j2#L21)

For the images to be updated in the CI jobs, they need to have this tag:
https://opendev.org/openstack/tripleo-common/src/branch/master/tripleo_common/image/kolla_builder.py#L342-L344
https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/undercloud-deploy/templates/containers-prepare-parameter.yaml.j2#L12-L13

Otherwise they'll be skipped. The undercloud will deploy non updated images (and not fail) and the minion node will try to deploy the updated images and fail, since they didn't build.

So there are 3 identified issues:

1) Ansible didn't report a failure when minion failed to deploy (even if tripleoclient reported RC 1).

2) New container images need a specific label and this label needs to be allowed in "modify_only_with_labels" (in tripleo-quickstart-extras)

3) Figure out why the undercloud didn't fail to deploy since it's supposed to use the -updated images, but it seems it fell back on the non updated ones.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-quickstart-extras (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/740298

Emilien Macchi (emilienm)
Changed in tripleo:
assignee: nobody → Emilien Macchi (emilienm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/740332

Revision history for this message
Emilien Macchi (emilienm) wrote :

1) maybe the fix is https://review.opendev.org/740332

2) the short term fix will be https://review.opendev.org/#/c/740296/ and the long term is https://review.opendev.org/#/c/740323

3) I checked and this is an expected behaviour I think, so there is no bug here.

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/740296
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=af74c389e4d73041c2a052e633f8e3f7efaa550d
Submitter: Zuul
Branch: master

commit af74c389e4d73041c2a052e633f8e3f7efaa550d
Author: Emilien Macchi <email address hidden>
Date: Thu Jul 9 09:49:39 2020 -0400

    Relax filter_images_with_labels() and re-add kolla_version

    This patch does 2 things (on purpose for easier backport without CI
    failures):

    1) TCIB: add "kolla_version" for backward compatibility

    In TripleO CI, we run container updates using tripleo-modify-image role
    but only for the images with "kolla_version" label.

    https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/undercloud-deploy/templates/containers-prepare-parameter.yaml.j2#L13

    In the future, we'll rename this LABEL to be more TCIB specific and
    remove "kolla" from it, but for now let's have it for backward
    compatibility.

    2) image_uploader: relax logic for filter_images_with_labels()

    modify_only_with_labels is a list of labels that can be set to find out
    what images we want to modify with the tripleo-modify-image role.

    Before, all the items in the list must be present in the image Labels;
    which is too strict (e.g. kolla_version label used by quickstart doesn't
    exist in the new images with TCIB).

    Let's relax it so we will modify the image if at least one label is
    present in there.

    Related-Bug: #1886914
    Change-Id: Ia9b75f8a50c83fc38d7a4f6d5e6a9726d82fbd8c

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (stable/ussuri)

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/740452

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.opendev.org/740332

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-quickstart-extras (master)

Fix proposed to branch: master
Review: https://review.opendev.org/740722

Changed in tripleo:
assignee: Emilien Macchi (emilienm) → Alex Schultz (alex-schultz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (stable/ussuri)

Reviewed: https://review.opendev.org/740452
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=d8d398dc7cd01c94e2a11dc2912a598029c7b29e
Submitter: Zuul
Branch: stable/ussuri

commit d8d398dc7cd01c94e2a11dc2912a598029c7b29e
Author: Emilien Macchi <email address hidden>
Date: Thu Jul 9 09:49:39 2020 -0400

    Relax filter_images_with_labels() and re-add kolla_version

    This patch does 2 things (on purpose for easier backport without CI
    failures):

    1) TCIB: add "kolla_version" for backward compatibility

    In TripleO CI, we run container updates using tripleo-modify-image role
    but only for the images with "kolla_version" label.

    https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/undercloud-deploy/templates/containers-prepare-parameter.yaml.j2#L13

    In the future, we'll rename this LABEL to be more TCIB specific and
    remove "kolla" from it, but for now let's have it for backward
    compatibility.

    2) image_uploader: relax logic for filter_images_with_labels()

    modify_only_with_labels is a list of labels that can be set to find out
    what images we want to modify with the tripleo-modify-image role.

    Before, all the items in the list must be present in the image Labels;
    which is too strict (e.g. kolla_version label used by quickstart doesn't
    exist in the new images with TCIB).

    Let's relax it so we will modify the image if at least one label is
    present in there.

    Related-Bug: #1886914
    Change-Id: Ia9b75f8a50c83fc38d7a4f6d5e6a9726d82fbd8c

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/743260

Emilien Macchi (emilienm)
Changed in tripleo:
milestone: victoria-1 → victoria-3
Alex Schultz (alex-schultz)
Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-quickstart-extras (master)

Reviewed: https://review.opendev.org/740298
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=9da8187e0b75137ccab833b682199ebcf218a175
Submitter: Zuul
Branch: master

commit 9da8187e0b75137ccab833b682199ebcf218a175
Author: Emilien Macchi <email address hidden>
Date: Thu Jul 9 09:52:26 2020 -0400

    containers: add tcib_managed label to authorized images to be updated

    For containers to be updated by tripleo-modify-image, they need a
    special label. For now it was only "kolla_version" for TripleO CI, but
    since we have new images which don't use Kolla, we now have the
    tcib_managed that we'll use.

    Related-Bug: #1886914
    Change-Id: I3fef7509b03b086727638e737a7d6eb2bbec47f9

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (stable/train)

Reviewed: https://review.opendev.org/743260
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=a3ccf6fb01993a2061fb5be0b188eb58c83ce83f
Submitter: Zuul
Branch: stable/train

commit a3ccf6fb01993a2061fb5be0b188eb58c83ce83f
Author: Emilien Macchi <email address hidden>
Date: Thu Jul 9 09:49:39 2020 -0400

    Relax filter_images_with_labels() and re-add kolla_version

    This patch does 2 things (on purpose for easier backport without CI
    failures):

    1) TCIB: add "kolla_version" for backward compatibility

    In TripleO CI, we run container updates using tripleo-modify-image role
    but only for the images with "kolla_version" label.

    https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/undercloud-deploy/templates/containers-prepare-parameter.yaml.j2#L13

    In the future, we'll rename this LABEL to be more TCIB specific and
    remove "kolla" from it, but for now let's have it for backward
    compatibility.

    2) image_uploader: relax logic for filter_images_with_labels()

    modify_only_with_labels is a list of labels that can be set to find out
    what images we want to modify with the tripleo-modify-image role.

    Before, all the items in the list must be present in the image Labels;
    which is too strict (e.g. kolla_version label used by quickstart doesn't
    exist in the new images with TCIB).

    Let's relax it so we will modify the image if at least one label is
    present in there.

    Related-Bug: #1886914
    Change-Id: Ia9b75f8a50c83fc38d7a4f6d5e6a9726d82fbd8c
    (cherry picked from commit af74c389e4d73041c2a052e633f8e3f7efaa550d)

tags: added: in-stable-train
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.