ceph_dashboard listener in haproxy is created when it shouldn't

[Giulio Fidente]

ceph_dashboard listener is created in haproxy.cfg when dashboard is disabled; causing upgrade to stop and fail when checking for haproxy backends status (dashboard never comes back UP)

Probably due to condition in [1] which is mistakenly assuming dashboard in haproxy to be provisioned when mgr is enabled

1. https://github.com/openstack/puppet-tripleo/blob/stable/train/manifests/haproxy.pp#L667

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/737983
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=a21b5ee7ce44270828a12b823b33e5e4117bf4c1
Submitter: Zuul
Branch: master

commit a21b5ee7ce44270828a12b823b33e5e4117bf4c1
Author: Francesco Pantano <email address hidden>
Date: Thu Jun 25 13:25:44 2020 +0200

    Fix haproxy ceph dashboard condition

    If grafana is not enabled in the overcloud the
    dashboard section shouldn't be created. We
    currently hit an issue during upgrades because
    the haproxy exists (because of ceph_mgr_enabled)
    even though the dashboard bits aren't deployed.
    Using the same condition for both services should
    be safe enough.

    Closes-Bug: #1885122
    Co-Authored-By: Giulio Fidente <email address hidden>
    Change-Id: I70d2ef2a64f0a46203d7a60b564eaa287e5708d6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/739043

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/739044

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/739043
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=30c8cb3b1bdda695621e0db5674cc55c6c5dd7a8
Submitter: Zuul
Branch: stable/ussuri

commit 30c8cb3b1bdda695621e0db5674cc55c6c5dd7a8
Author: Francesco Pantano <email address hidden>
Date: Thu Jun 25 13:25:44 2020 +0200

    Fix haproxy ceph dashboard condition

    If grafana is not enabled in the overcloud the
    dashboard section shouldn't be created. We
    currently hit an issue during upgrades because
    the haproxy exists (because of ceph_mgr_enabled)
    even though the dashboard bits aren't deployed.
    Using the same condition for both services should
    be safe enough.

    Closes-Bug: #1885122
    Co-Authored-By: Giulio Fidente <email address hidden>
    Change-Id: I70d2ef2a64f0a46203d7a60b564eaa287e5708d6
    (cherry picked from commit a21b5ee7ce44270828a12b823b33e5e4117bf4c1)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/739044
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=90a28fd10a259dd1e4d354fa739817caa911639c
Submitter: Zuul
Branch: stable/train

commit 90a28fd10a259dd1e4d354fa739817caa911639c
Author: Francesco Pantano <email address hidden>
Date: Thu Jun 25 13:25:44 2020 +0200

    Fix haproxy ceph dashboard condition

    If grafana is not enabled in the overcloud the
    dashboard section shouldn't be created. We
    currently hit an issue during upgrades because
    the haproxy exists (because of ceph_mgr_enabled)
    even though the dashboard bits aren't deployed.
    Using the same condition for both services should
    be safe enough.

    Depends-On: I1229d3a0cd2f08dabdcd3b47d9823f6a939cfbdb
    Closes-Bug: #1885122
    Co-Authored-By: Giulio Fidente <email address hidden>
    Change-Id: I70d2ef2a64f0a46203d7a60b564eaa287e5708d6
    (cherry picked from commit a21b5ee7ce44270828a12b823b33e5e4117bf4c1)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 11.5.0 release.