Search Service broken on Ubuntu Nightly builds

[Emma Humphries]

Search Service broken on Ubuntu Nightly builds.As reported in the Mozilla bug tracker, the search service has broken on the Ubuntu nightly builds.

https://bugzilla.mozilla.org/show_bug.cgi?id=1647576

It is broken due to this patch: https://bazaar.launchpad.net/~mozillateam/firefox/firefox.groovy/view/head:/debian/patches/cleanup-old-distribution-search-engines.patch

The code surrounding that has changed, however it should not be necessary now anyway, as we fixed the issues with distributions and built-in engines back in 76 (https://bugzilla.mozilla.org/show_bug.cgi?id=1623597).

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Rico Tzschichholz (ricotz)]

This should be fixed with the 79.0~a1~hg20200625r537324 builds

https://bazaar.launchpad.net/~mozillateam/firefox/firefox-trunk.head/revision/2342

[Standard8 (mbanner)]

Rico, as we said in the original comment, that patch is no longer necessary.

The original issue that caused that to be necessary is now fixed (https://bugzilla.mozilla.org/show_bug.cgi?id=1623597).

Distribution engines are now loaded first, marked as builtin/app-provided. Worst case, removing that patch completely might cause a few errors on the console about an engine already being installed the first time a user upgrades from a version before 76. However that error should have no user impact.

If you don't remove it now you should at least mark it for removing in a release or two as it isn't necessary. If you find it is still necessary, please let me know and we can take a look at it.