pid file of rsync is re-enabled when updating overcloud stack

Bug #1884671 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Unassigned

Bug Description

Since the following patch was introduced we expect "pid file" is removed from rsyncd.conf to avoid the issue caused by pid file remaining in the container because of some reasons like force shutdown.
https://review.opendev.org/#/c/577403/

This works as expected in initial deployment.
However, the swift_rsync_fix is not invoked when updating overcloud stack, and this causes "pid file" remains in rsyncd.conf after puppet reapplies the configuration.

Changed in tripleo:
assignee: nobody → Takashi Kajinami (kajinamit)
status: New → In Progress
Changed in tripleo:
milestone: none → victoria-1
tags: added: idempotency queens-backport-potential stein-backport-potential train-backport-potential
Changed in tripleo:
importance: Undecided → Medium
Changed in tripleo:
milestone: victoria-1 → victoria-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Takashi Kajinami (<email address hidden>) on branch: master
Review: https://review.opendev.org/737391

Changed in tripleo:
milestone: victoria-3 → wallaby-1
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Changed in tripleo:
milestone: wallaby-3 → wallaby-rc1
Changed in tripleo:
milestone: wallaby-rc1 → xena-1
Revision history for this message
Takashi Kajinami (kajinamit) wrote :

This was already fixed during Victoria cycle and and the fix has been backported to Train and Ussuri.
 https://review.opendev.org/c/openstack/tripleo-heat-templates/+/739859

Changed in tripleo:
assignee: Takashi Kajinami (kajinamit) → nobody
status: In Progress → Fix Released
milestone: xena-1 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.