TOD build dependencies are missing packages

Bug #1884267 reported by Marco Trevisan (Treviño)
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libfprint (Ubuntu)
Fix Released
Medium
Marco Trevisan (Treviño)
Focal
Fix Released
Undecided
Unassigned

Bug Description

Compiling a TOD package from source by build-depending only on libfprint-2-tod-dev, does not work, as the tod-dev package has misses the .pc dependencies.

❯ less /usr/lib/x86_64-linux-gnu/pkgconfig/libfprint-2-tod-1.pc
prefix=/usr
libdir=${prefix}/lib/x86_64-linux-gnu
includedir=${prefix}/include

tod_driversdir=${libdir}/libfprint-2/tod-1

Name: libfprint-2-tod
Description: Private Libfprint Touch Drivers API
Version: 1.90.1+tod1+tod1
Requires.private: gio-unix-2.0 >= 2.56, glib-2.0 >= 2.56, gusb >= 0.2.0, pixman-1, nss, gmodule-2.0 >= 2.56, libfprint-2
Libs: -L${libdir} -lfprint-2-tod
Libs.private: -lm
Cflags: -I${includedir}/libfprint-2/tod-1

[ Impact ]

No possible to compile TOD packages without manual depenencies

[ Test case ]

Try with this driver https://gitlab.freedesktop.org/3v1n0/libfprint-tod-vfs0090/-/tree/tod-deps-test

 git clone https://gitlab.freedesktop.org/3v1n0/libfprint-tod-vfs0090 -b tod-deps-test
 gbp buildpackage -b

Should work

[ Regression potential ]

Installed dependencies may cause a conflict

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libfprint - 1:1.90.2+tod1-0ubuntu1

---------------
libfprint (1:1.90.2+tod1-0ubuntu1) groovy; urgency=medium

  * New upstream release
    - Fixed crash in VFS0050 (LP: #1876502)
    - Enrollment fails with UPEK reader (LP: #1881380)
    - Lots of various drivers fixes
    - As per a patch for nbis required for some sensors that was accidentally
      dropped in an earlier release. Users of sensors/drivers aes1610, aes2501,
      aes2550, aes1660, aes2660, elan, upektc_img) need to re-enroll
  * d/p/git_reading_pointer.patch:
    - Dopped (applied upstream)
  * debian/control: Add missing libfprint-2-tod-dev dependencies (LP: #1884267)
  * debian/rules: Be strictier about symbol changes
  * libfprint-2-tod1.symbols: Add new TOD symbols

 -- Marco Trevisan (Treviño) <email address hidden> Fri, 19 Jun 2020 17:38:55 +0200

Changed in libfprint (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Proposed package upload rejected

An upload of libfprint to focal-proposed has been rejected from the upload queue for the following reason: "No bug references and/or SRU information for "New upstream release" and "Lots of various driver fixes"; incomplete discussion of regression potential in all bugs that are referenced. Please see https://wiki.ubuntu.com/StableReleaseUpdates for the required information and procedure.".

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Marco, or anyone else affected,

Accepted libfprint into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.90.2+tod1-0ubuntu1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libfprint (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Correctly built with

unstable /tmp/libfprint-tod-vfs0090 tod-deps-test 00:25:44
❯ gbp buildpackage -b -k$GPGKEY --git-ignore-new --git-builder=sbuild -A -v -d focal-amd64 --build-failed-commands=%s

❯ apt-cache policy libfprint-2-tod-dev
libfprint-2-tod-dev:
  Installato: 1:1.90.2+tod1-0ubuntu1~20.04.1
  Candidato: 1:1.90.2+tod1-0ubuntu1~20.04.1
  Tabella versione:
 *** 1:1.90.2+tod1-0ubuntu1~20.04.1

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libfprint - 1:1.90.2+tod1-0ubuntu1~20.04.1

---------------
libfprint (1:1.90.2+tod1-0ubuntu1~20.04.1) focal; urgency=medium

  * New upstream release (LP: #1887822)
    - Fixed crash in VFS0050 (LP: #1878285)
    - Enrollment fails with UPEK reader (LP: #1881380)
    - As per a patch for nbis required for some sensors that was accidentally
      dropped in an earlier release. Users of sensors/drivers aes1610, aes2501,
      aes2550, aes1660, aes2660, elan, upektc_img) need to re-enroll
  * d/p/git_reading_pointer.patch:
    - Dopped (applied upstream)
  * debian/control: Add missing libfprint-2-tod-dev dependencies (LP: #1884267)
  * debian/rules: Be strictier about symbol changes
  * libfprint-2-tod1.symbols: Add new TOD symbols
  * debian/{control, gbp.conf}: prepare for focal branching

 -- Marco Trevisan (Treviño) <email address hidden> Thu, 16 Jul 2020 18:06:19 +0200

Changed in libfprint (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for libfprint has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.