tripleoclient fails to build on delorean: ModuleNotFoundError: No module named 'tripleo_common.actions.config'

Bug #1884138 reported by Emilien Macchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Emilien Macchi

Bug Description

After https://review.opendev.org/#/c/734424/ landed, tripleoclient fails to build:
https://review.rdoproject.org/r/#/c/28151/

DEBUG: tripleoclient.tests.workflows.test_baremetal.TestBaremetalWorkflows.test_provide_success
DEBUG: ----------------------------------------------------------------------------------------
DEBUG: Captured traceback:
DEBUG: ~~~~~~~~~~~~~~~~~~~
DEBUG: Traceback (most recent call last):
DEBUG: File "/usr/lib/python3.6/site-packages/mock/mock.py", line 1222, in _dot_lookup
DEBUG: return getattr(thing, comp)
DEBUG: AttributeError: module 'tripleo_common.actions' has no attribute 'config'
DEBUG:
DEBUG: During handling of the above exception, another exception occurred:
DEBUG:
DEBUG: Traceback (most recent call last):
DEBUG: File "/builddir/build/BUILD/python-tripleoclient-13.4.0.dev27/tripleoclient/tests/workflows/test_baremetal.py", line 24, in setUp
DEBUG: super(TestBaremetalWorkflows, self).setUp()
DEBUG: File "/builddir/build/BUILD/python-tripleoclient-13.4.0.dev27/tripleoclient/tests/fakes.py", line 193, in setUp
DEBUG: config_mock.start()
DEBUG: File "/usr/lib/python3.6/site-packages/mock/mock.py", line 1525, in start
DEBUG: result = self.__enter__()
DEBUG: File "/usr/lib/python3.6/site-packages/mock/mock.py", line 1378, in __enter__
DEBUG: self.target = self.getter()
DEBUG: File "/usr/lib/python3.6/site-packages/mock/mock.py", line 1548, in <lambda>
DEBUG: getter = lambda: _importer(target)
DEBUG: File "/usr/lib/python3.6/site-packages/mock/mock.py", line 1235, in _importer
DEBUG: thing = _dot_lookup(thing, comp, import_path)
DEBUG: File "/usr/lib/python3.6/site-packages/mock/mock.py", line 1224, in _dot_lookup
DEBUG: __import__(import_path)
DEBUG: ModuleNotFoundError: No module named 'tripleo_common.actions.config'

We should remove all references of this module and then remove it again.

Changed in tripleo:
milestone: none → victoria-1
assignee: nobody → Emilien Macchi (emilienm)
importance: Undecided → Critical
status: New → Triaged
Changed in tripleo:
assignee: Emilien Macchi (emilienm) → Alex Schultz (alex-schultz)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/736835

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.opendev.org/736878

Changed in tripleo:
assignee: Alex Schultz (alex-schultz) → Emilien Macchi (emilienm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/736835
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c915208fee4d15d9450514a6a5de6bdc5cc6f12f
Submitter: Zuul
Branch: master

commit c915208fee4d15d9450514a6a5de6bdc5cc6f12f
Author: Emilien Macchi <email address hidden>
Date: Thu Jun 18 20:48:07 2020 +0000

    Revert "Remove config-download related mistral actions"

    See bug report, it broke tripleoclient.

    This reverts commit 2c47084bc926b90c86e8b5b6de51aaffd1c8b39d.
    Related-Bug: #1884138

    Change-Id: Ib86c92a9607a42f5a743d69026f37efcadb55553

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/736816
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=adf29a1e706b7dd72a7322a29093e7d07647f882
Submitter: Zuul
Branch: master

commit adf29a1e706b7dd72a7322a29093e7d07647f882
Author: Alex Schultz <email address hidden>
Date: Thu Jun 18 13:36:35 2020 -0600

    Remove actions.config and AnsibleGenerateInventoryAction references

    I493ec949e09a1a1a1745f4bf161bc6d3dc185e1e removed
    tripleo_common.actions.config so these no longer should be mocked. This
    causes build failures in dlrn.

    If5053530eeadd277db091d60bc9095aa7f05d67f removed
    AnsibleGenerateInventoryAction so we don't need to mock it.

    Closes-Bug: #1884138
    Change-Id: I9558f70d333b340bbd81065f014fc207f5ac6563

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.opendev.org/736878

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.