tripleo

Neutron OVS agent' neutron.cmd.destroy_patch_ports can introduce dataplane downtime

Bug #1884048 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Invalid
High
Unassigned
tripleo victoria-1 "tripleo victoria"

Bug Description

For neutron ovs agent container, neutron.cmd.destroy_patch_ports is called after the agent has stopped and before it is started.

Presumably (just my guess), that introduces undesired dataplane downtime.

Related https://bugzilla.redhat.com/show_bug.cgi?id=1847835

See original description
Bogdan Dobrelya (bogdando)
Changed in tripleo:
importance: Undecided → High
tags: added: queens-backport-potential train-backport-potential ussuri-backport-potential
Changed in tripleo:
milestone: none → victoria-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-ansible (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/736524

Changed in tripleo:
assignee: nobody → Bogdan Dobrelya (bogdando)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/736525

Revision history for this message
Bogdan Dobrelya (bogdando) wrote : Re: Neutron OVS agent should call neutron.cmd.destroy_patch_ports before the agent stopped

Also addressed by https://review.rdoproject.org/r/28141

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/736524
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=26abebb29317bc9855ceee5f4ab8a33ec6bd8f8d
Submitter: Zuul
Branch: master

commit 26abebb29317bc9855ceee5f4ab8a33ec6bd8f8d
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Jun 18 12:08:23 2020 +0200

    Add pre stop exec hook for container systemd units

    Sometimes, actions taken as the part of a container's entrypoint script
    should become the pre-stop actions. Allow such configurations composed
    for managed containers.

    Change-Id: I40237e2b35ce83c5b519a117a6d4e74cb845b2c3
    Related-bug: #1884048
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Revision history for this message
Bogdan Dobrelya (bogdando) wrote : Re: Neutron OVS agent should call neutron.cmd.destroy_patch_ports before the agent stopped

I'm setting this to incomplete since it has to be confirmed by networking/ovs and neutron experts.

Changed in tripleo:
status: In Progress → Incomplete
assignee: Bogdan Dobrelya (bogdando) → nobody
summary: - Neutron OVS agent should call neutron.cmd.destroy_patch_ports before
- the agent stopped
+ Neutron OVS agent' neutron.cmd.destroy_patch_ports can introduce
+ dataplane downtime
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Bogdan Dobrelya (bogdando) (<email address hidden>) on branch: master
Review: https://review.opendev.org/736525
Reason: https://review.opendev.org/#/c/733568

Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

https://bugs.launchpad.net/neutron/+bug/1869808

Changed in tripleo:
status: Incomplete → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/737244

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/737244
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=554844d32045e3a774a3e90bbd26812aecd92b50
Submitter: Zuul
Branch: master

commit 554844d32045e3a774a3e90bbd26812aecd92b50
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Jun 18 12:00:48 2020 +0200

    Log neutron.cmd.destroy_patch_ports in to log file

    Align the logging arguments to be used consistently
    with the script and the main agent command invoked in the container.

    Change-Id: I36b4f4abaa2e67448783d4fbaf8864d16656baf2
    Related-bug: #1884048
    Signed-off-by: Bogdan Dobrelya <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.