lang package installation happens before mirrors get overridden

[Gaël THEROND]

What happened:

When performing a build of the base image in an offline mode (mirroring everything internally), the language packages installation block is reached before any OS package repository file addition/override and so doesn't work as it try to use official online repositories that can't be reached.

What should happen:

The language related packages installation block should be triggered right after the repository override block instead of before.
Doing that will allow for a clean workflow, avoid useless override within template-override.j2 file or dirty dnf.conf file containing an endless list of repositories while still keeping the same behavior than before for online installations.

How to reproduce:

Launch a build of the kolla base image in an offline mode, the language packs won't install as they're not able to reach internet repositories and consequently fail the build.

**Environment**
OS: CentOS-8.1.1911
Kernel:4.18.0-147
Docker version: 19.03
Kolla version: 9.1.0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/735346

[Gaël THEROND (gtherond)]

I just submitted the patch for this issue, if anyone want to discuss that, feel free to talk!

https://review.opendev.org/#/c/735346/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/735346
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=f9def021d86caecfd57018f41792f8a7c6bc6a80
Submitter: Zuul
Branch: master

commit f9def021d86caecfd57018f41792f8a7c6bc6a80
Author: Gaël THEROND <email address hidden>
Date: Fri Jun 12 16:22:22 2020 +0200

    Change lang package block order

    Fix offline installation of language pack packages.
    Change-Id: I9f4a21bbf1c8383e21e59350206aba3424602270
    Closes-bug: #1883233

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/738255

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/738256

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/738256
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=97d74c37b62223a9f61a9b0fdb5e316d18fb4fab
Submitter: Zuul
Branch: stable/train

commit 97d74c37b62223a9f61a9b0fdb5e316d18fb4fab
Author: Gaël THEROND <email address hidden>
Date: Fri Jun 12 16:22:22 2020 +0200

    Change lang package block order

    Fix offline installation of language pack packages.
    Change-Id: I9f4a21bbf1c8383e21e59350206aba3424602270
    Closes-bug: #1883233
    (cherry picked from commit f9def021d86caecfd57018f41792f8a7c6bc6a80)
    (cherry picked from commit 714e1feaea947b6a014d34e5a9cecfc777472ca1)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/738255
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=714e1feaea947b6a014d34e5a9cecfc777472ca1
Submitter: Zuul
Branch: stable/ussuri

commit 714e1feaea947b6a014d34e5a9cecfc777472ca1
Author: Gaël THEROND <email address hidden>
Date: Fri Jun 12 16:22:22 2020 +0200

    Change lang package block order

    Fix offline installation of language pack packages.
    Change-Id: I9f4a21bbf1c8383e21e59350206aba3424602270
    Closes-bug: #1883233
    (cherry picked from commit f9def021d86caecfd57018f41792f8a7c6bc6a80)