Can't store multiple deployment flavours data in nested_tosca_templates_with_topology

[Ayumu Ueha]

Bug Description:

When user tries to load CSAR file with multiple flavours (eg: simple, complex [attached zip file]) of VNFD, it only stores one object in nested_tosca_templates_with_topology.

Following is the format of CSAR file.

csar
  |
  Definitions
      |
     etsi_nfv_sol001_common_types.yaml
     etsi_nfv_sol001_vnfd_types.yaml
     helloworld3_df_complex.yaml
     helloworld3_df_simple.yaml
     helloworld3_top.vnfd.yaml
     helloworld3_types.yaml
  TOSCA-Metadata
      |
     TOSCA.meta

It should be multiple objects in nested_tosca_templates_with_topology if CSAR file with multiple deployment flavours.
(nested_tosca_tpls_with_topology has multiple objects.)

Observation:
The reason why tosca-parser adds only one nested tosca template is because of method ``_is_sub_mapped_node`` returns false as it finds sub_mapping_tosca_template　is already set.

[Ayumu Ueha (ueha)]

Hi tosca-parser teams!
I'm working with tacker project.

Original bug ticket is https://bugs.launchpad.net/tacker/+bug/1881219.
This problem seems to occur by tosca-parser's bug.

It seems to work fine if I remove `not nodetemplate.sub_mapping_tosca_template` from the if expression in method `_is_sub_mapped_node`.

So I will push a patch fix as above, and could you check this details and patch contents.
Thanks!

[Itsuro Oda (oda-g)]

Fix Released. https://review.opendev.org/#/c/735311

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tosca-parser 2.2.0 release.