collection pages unvailable as link options in tinyMCE

[Lisa Seeto]

When inserting a link using the tinyMCE editor the drop down for "Link List" options should display all pages including pages in a collection. This functionality existing in 19.04 (see attached screen shot 'tinyMCE-collections.png') but had changed in 19.10 and now no longer offers the option. It should return to its previous function.

Affects Mahara 19.10, 20.04.

To test:
1. On 19.04, create a collection (1 page is fine) and a portfolio page.
2. Edit the portfolio page and select a text block. In the tinyMCE editor select to insert a link and in the pop-up box, select the drop-down for "Link List".
3. See that the link list options contain the collection page(s)
4. Upgrade to 19.10 and perform, edit the portfolio page and click to accept the grid stack transformation
5. Edit the text block and select to insert a link, select the drop-down for "Link List"
Expected results:
All pages including the collection->pages display
Actual results:
The collection pages are not included.

[Lisa Seeto (lisaseeto)]

It appears that nested link lists were not supported in tinyMCE version 5:

https://community.tiny.cloud/communityQuestion?id=9064N000000EUKbQAO
https://github.com/tinymce/tinymce/issues/4822

It seems like we're going to have to return the collection page data in a different way.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11020

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11020
Committed: https://git.mahara.org/mahara/mahara/commit/c33aa85a8cfba1414999e2682b810d2eb6399c4d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c33aa85a8cfba1414999e2682b810d2eb6399c4d
Author: Lisa Seeto <email address hidden>
Date: Thu Jun 11 17:30:09 2020 +1200

Bug 1883043: collection pages unvailable as link options in tinymce

- removed the nested link list format for collections as this
feature is no longer under support in tinymce from version 5

Change-Id: I2cb089100e939f3b48d11bc95523bc2474aff166
Signed-off-by: Lisa Seeto <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11026

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11026
Committed: https://git.mahara.org/mahara/mahara/commit/6fca48fc5eb5bd7e627242903d3a3feb178bc0dd
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 6fca48fc5eb5bd7e627242903d3a3feb178bc0dd
Author: Lisa Seeto <email address hidden>
Date: Thu Jun 11 17:30:09 2020 +1200

Bug 1883043: collection pages unvailable as link options in tinymce

- removed the nested link list format for collections as this
feature is no longer under support in tinymce from version 5

Change-Id: I2cb089100e939f3b48d11bc95523bc2474aff166
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit c33aa85a8cfba1414999e2682b810d2eb6399c4d)

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11027

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11027
Committed: https://git.mahara.org/mahara/mahara/commit/5f70a6393b5ee18c8e2ce5f38e49d0573744d62e
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 5f70a6393b5ee18c8e2ce5f38e49d0573744d62e
Author: Lisa Seeto <email address hidden>
Date: Thu Jun 11 17:30:09 2020 +1200

Bug 1883043: collection pages unvailable as link options in tinymce

- removed the nested link list format for collections as this
feature is no longer under support in tinymce from version 5

Change-Id: I2cb089100e939f3b48d11bc95523bc2474aff166
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit c33aa85a8cfba1414999e2682b810d2eb6399c4d)
(cherry picked from commit 6fca48fc5eb5bd7e627242903d3a3feb178bc0dd)

[Dianne Tennent (dianne-t)]

Release testing:
Cloud
MySQL 8
Firefox
Maroon theme
PHP 7.4

Fixed released in 2020. Appears as per attached screenshot.