Booking : Pull List - catalogued resources are not showing on pull list

Bug #1882828 reported by Christine Burns
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.4
Fix Released
Medium
Unassigned

Bug Description

EG3.4 +

Issue with Catalogued resources not showing on the pull list

If only one catalogued resource is on the pull list - it shows as expected

If more than one catalogued resource appears on the pull list - none of the catalogued items appear on the pull list

See screenshots

error message appears in the console

9.6902d868a42eab621505.js:1 No cellTextGenerator provided for "CONC4400040"
ngOnInit @ 9.6902d868a42eab621505.js:1
9.6902d868a42eab621505.js:1 No cellTextGenerator provided for "CONC4400040"
ngOnInit @ 9.6902d868a42eab621505.js:1
main.3726100466aecefca6cd.js:1
      It looks like you're using the disabled attribute with a reactive form directive. If you set disabled to true
      when you set up this control in your component class, the disabled attribute will actually be set in the DOM for
      you. We recommend using this approach to avoid 'changed after checked' errors.

      Example:
      form = new FormGroup({
        first: new FormControl({value: 'Nancy', disabled: true}, Validators.required),
        last: new FormControl('Drew', Validators.required)
      });

Revision history for this message
Christine Burns (christine-burns) wrote :
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for catching this, Christine.

Here's a branch that should help: user/sandbergja/lp1882828_booking_pull_list_cataloged_resources

Link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1882828_booking_pull_list_cataloged_resources

tags: added: pullrequest
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Jane Sandberg (sandbergja) wrote :

P.S. I think those console errors/warnings were being generated by another screen, and then remained in the console while on the pull list.

Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
Changed in evergreen:
milestone: none → 3.5.2
Revision history for this message
Terran McCanna (tmccanna) wrote :

I created multiple reservations for cataloged resources and they all appeared on the pull list. My signoff at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1882828_booking_pull_list_cataloged_resources_signoff

tags: added: signedoff
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed all the way to rel_3_4. Thanks, Jane and Terran!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.