Unable to exit fullscreen mode Windows 2.3.0-beta (build 2.3 r7439)

[patchtheuniform]

* application was last run in fullscreen manually prior to upgrade
* opens in fullscreen automatically on start up
* run in fullscreen is _not_ configured in Preferences > Interface
* press F11 does not toggle fullscreen mode
* manually selecting the fullscreen item from the View menu does not toggle fullscreen mode
* was working in previous 2.2.3 installation

OS Name Microsoft Windows 10 Home
Version 10.0.18363 Build 18363
System Type x64-based PC
Processor Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz, 3601 Mhz, 4 Core(s), 8 Logical Processor(s)

[ronso0 (ronso0)]

I can confirm that Mixxx starts in fullscreen even though Pref > Interface > Fullscreen is unchecked.

F11 still works to toggle fullscreen on Linux.

[geozubuntu (geozubuntu)]

Linux Mint 19.3 (ubuntu bionic) amd mixxx 2.3.0-beta (build 2.3 r7443) F11 DOESN'T work.

If Mixxx starts in windowed mode do the following:

1. Click View - SELECT checkbox fullscreen ---> turns fullscreen on and check box appears selected correctly.
2. Close mixxx.
3. Rerun mixxx ---> it starts in fullscreen mode (correct since it was closed in fullscreen mode)BUT
4. Click View - checkbox Fullscreen appears UNSELECTED (faultly since mixxx is in fullscreen mode).
5. Click View - CLICK checkbox fullscreen ---> now appears selected and nothing else happens (mixxx is already in fullscreen mode).
6. Click View - UNSELECT checkbox Fullscreen ---> mixxx leaves fullscreen, returns to windowed mode as it should do.
7. Exit mixxx
8. Rerun mixxx ---> it starts correctly in windowed mode.

If mixxx starts in fullscreen mode start from step 4.

In all cases F11 DOESN't work at all no matter if it is in windowed or fullscreen mode.

So the problem is the faulty indication of checkbox when mixxx starts in fullscreen and F11 lack of operation

[ronso0 (ronso0)]

so the changes from https://github.com/mixxxdj/mixxx/pull/2735/files are not working?

that puzzles me because the code is present in both 2.3 and master and it works always on Linux.
https://github.com/mixxxdj/mixxx/blob/2.3/src/widget/wmainmenubar.cpp#L265
https://github.com/mixxxdj/mixxx/blob/master/src/widget/wmainmenubar.cpp#L265

[ronso0 (ronso0)]

@geozubuntu What Fullscreen shortcut is printed in the menu for you?

[Stefan (nopeppermint)]

@ronso0

I just compiled current branch 2.3 (https://github.com/mixxxdj/mixxx/commit/340d37edd33e16e5dbe05edee4d1c49bc04b4247) on Linux Mint 19.3, Cinnamon
Scons v 3.01
Python v 2.7.17
x86_64

and F11 is not working on my pc either!

without the changes from https://github.com/mixxxdj/mixxx/pull/2735 F11 is working to toggle from/to full-screen!

>@geozubuntu What Fullscreen shortcut is printed in the menu for you?

I see there (with and without PR 2735) F11 as shortcut.

[ronso0 (ronso0)]

Discussion happens in https://github.com/mixxxdj/mixxx/pull/2735

[ronso0 (ronso0)]

please test https://github.com/mixxxdj/mixxx/pull/3011, this aims to fix the issue when the OS does not supply a fullscreen shortcut (or this is F11 already).

[geozubuntu (geozubuntu)]

Sorry for the delayed answer. I was in trouble with my laptop.

So on Mint 19.3 the 2.4.0-alpha-pre (build master r7493) shows F11 for the fullscreen but it is not working.
In the menu the shortcut printed is F11 for the fullscreen. All the rest options printed are :

Show skin settings Ctrl+1
show microphone Ctrl+2
Show vinyl control Ctrl+3
show preview deck ctrl+4
show cover art ctrl+6
Maximize library space
-----------------
View fullscreen F11

F11 is not working.

Something very weird happens.
upon start of the program in the view menu all shortcuts and checkboxes are working except F11. The fullscreen option can only be selected by the checkbox. BUT...
After the first activation-deactivation of fullscreen (by the checkbox since F11 is not working) then ALLthe rest checkboxes appear all unchecked and they stop working and also no shortcut is working in view menu any more.

[ronso0 (ronso0)]

This is weird indeed, but possibly fixed by the changes of https://github.com/mixxxdj/mixxx/pull/3011

Could you please test if the AppVeyor windows build of that PR fixes this issue as well?
https://ci.appveyor.com/api/buildjobs/gplgyid638y8407b/artifacts/cmake_build%2Fmixxx.exe

Note: the PR is targeted at 2.3, so when installing the artifact simply run Mixxx from the command line and choose an empty (new) settings path for a clean profile to avoid a database downgrade (and re-upgrade in case yo install 2.4 later on).
Details are listed in the manual https://mixxx.org/manual/2.3/en/chapters/appendix.html#command-line-options.

Wether it works or not, please also go to https://github.com/mixxxdj/mixxx/pull/3011 and post that debug snippet from the terminal output which is printed while the launch screen is shown (easy to spot, looks like this for example https://github.com/mixxxdj/mixxx/pull/3011#issuecomment-672246125).

Thanks!

[ronso0 (ronso0)]

https://github.com/mixxxdj/mixxx/pull/3011 was just merged, please test with a 2.3 build from http://downloads.mixxx.org/builds/2.3/release/ as soon as it's uploaded.

[geozubuntu (geozubuntu)]

Unfortunately for me nothing changed on Linux Mint 19.3 and 2.3 beta (7329)
As I wrote above in my message #8 this weird behaviour continues exactly as I described there.
Note that I completely removed the previous installation and did a fresh install to eliminate the possibility of any possible conflict.

Additionally when I have opened the drop down menu my keyboard isn't operative !!!! I can't even take a screenshot because shortcut isn't working!!!! (It happens with every drop down menu) !!

I managed to have 3 screenshots by using delay to show how the menu behaves.

[geozubuntu (geozubuntu)]

See my posts #8 #11 #12 #13 and this one to have the full description.
Also find the Mixxx.log in case it can help.

I repeat it is a new installation.

[geozubuntu (geozubuntu)]

I will continue to test the next 2.3 versions and report here. Unfortunately I don't have windows yet at this time to see what happens there.

[ronso0 (ronso0)]

Please do so. The version you mentioned (r7329) is outdated.
latest version is r7544 at http://downloads.mixxx.org/builds/2.3/release/

[geozubuntu (geozubuntu)]

Tested 2.3 r7544 in linux Mint19.3 (bionic)

F11 works as it supposed to. This part is solved.

BUT
After the first activation of F11 nothing else works in the view menu.
Also ALL the rest checkboxes appear all unchecked and they stop working and also no other shortcut is working in view menu any more.

My comments #11 #12 #13 #14 above contain screenshots and descriptions which are still as described.

If you think it is another bug please link these comments in a new report, (I don't know how to do it).

Thanks.

[ronso0 (ronso0)]

it looks like the window state is saved and restored in mixxx.cfg regardless of
StartInFullscreen being '0'
and no --fullscreen command line option.

If I manually remove the 'geometry' key from the config Mixxx starts in window mode.
[MainWindow]
geometry ....

[ronso0 (ronso0)]

lp:1909485

follow-up fix is in https://github.com/mixxxdj/mixxx/pull/3493

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10005