Enable e1000e S0ix on Tiger Lake

Bug #1881996 reported by Hsuan-Yu Lin
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Undecided
Unassigned
linux-oem-5.6 (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Hsuan-Yu Lin

Bug Description

[SRU Justfication]

[Impact]

Enable e1000e S0ix on Tiger Lake for OEM-5.6.

[Fix]

Following fixes, currently landed in linux-next, are necessary for
Tiger Lake e1000e S0ix.

* commit 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case")
* commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")

Hsuan-Yu Lin (shanelin)
tags: added: oem-priority originate-from-1872029 somerville
Changed in linux-oem-5.6 (Ubuntu Focal):
assignee: nobody → Hsuan-Yu Lin (shanelin)
You-Sheng Yang (vicamo)
tags: added: hwe-networking-ethernet
Hsuan-Yu Lin (shanelin)
Changed in linux-oem-5.6 (Ubuntu):
status: New → Invalid
Changed in linux-oem-5.6 (Ubuntu Focal):
status: New → In Progress
Hsuan-Yu Lin (shanelin)
summary: - e1000e: fix S0ix flows for cable connected case
+ Enable e1000e S0ix on Tiger Lake
Hsuan-Yu Lin (shanelin)
description: updated
Revision history for this message
Hsuan-Yu Lin (shanelin) wrote :
Revision history for this message
Kai-Heng Feng (kaihengfeng) wrote :

Do note that "e1000e: disable s0ix entry and exit flows for ME systems" actually prevents most business laptops from reaching SLP_S0.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

so after further discussion, we decided to drop the second patch

Changed in linux-oem-5.6 (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Hsuan-Yu Lin (shanelin) wrote :
Download full text (8.3 KiB)

Discussion minutes from IRC #hwe (2020/06/12):

 15:37:35 <tjaalton> khfeng: so, should the e1000e commits be rejected, according to your comment on the bug?
 15:39:18 <khfeng> tjaalton, depends on kentlin_office. If we care about the power consumption under s0ix, then probably should reject it
 15:40:02 <tjaalton> ok, I'll drop it from the list for now
 15:40:27 <kentlin_office> tjaalton, khfeng, what commit
 15:41:05 <khfeng> kentlin_office, the one the prevents vPro systems from entering s0ix
 15:42:10 <kentlin_office> khfeng, oh.. we care about S0ix...
 15:42:43 <kentlin_office> khfeng, the patch is submitted by whom?
 15:44:52 <khfeng> kentlin_office, dunno
 15:45:02 <-- chih (chih@1-34-63-143.HINET-IP.hinet.net) has quit (Ping timeout: 121 seconds)
 15:45:29 <kentlin_office> khfeng, from upstream?
 15:45:31 --> chih (chih@61-220-137-34.HINET-IP.hinet.net) has joined #hwe
 15:45:55 <khfeng> kentlin_office, yea
 15:45:59 <tjaalton> intel
 15:47:05 <kentlin_office> tjaalton, in latest Kernel? do you have but or git cold share with me? I want to write email to Intel contact why they send such commit...
 15:50:38 <tjaalton> shane: ^
 15:55:04 <tjaalton> kentlin_office: it's in linus's git tree now
 15:55:11 <shane> tjaalton: got it, have talked with kentlin_office
 15:55:51 <tjaalton> what's the verdict?
 15:56:02 <tjaalton> should I drop both
 16:06:53 <-- jeremysu (jeremysu@61-220-137-37.HINET-IP.hinet.net) has quit (Ping timeout: 121 seconds)
 16:07:17 --> jeremysu (jeremysu@61-220-137-37.HINET-IP.hinet.net) has joined #hwe
 16:08:06 <tjaalton> khfeng: I can't find your e1000e commit in the trees where it was supposed to be applied already.. do you know what happened?
 16:08:19 <tjaalton> not in focal at least
 16:09:28 <khfeng> tjaalton, "e1000e: Disable TSO for buffer overrun workaround" this one?
 16:09:34 <tjaalton> yes
 16:11:38 --> ethanhsieh_home (ethan@1-171-165-81.dynamic-ip.hinet.net) has joined #hwe
 16:13:00 <tjaalton> perhaps I should ask the ones who applied it
 16:14:39 <tjaalton> it's in bionic at least
 16:14:46 <tjaalton> but not focal. probably a mistake
 16:14:54 <tjaalton> khfeng: so, nevermind :)
 16:15:12 <khfeng> Ok :)
 16:15:30 <-- ethanhsieh_home (ethan@1-171-165-81.dynamic-ip.hinet.net) has quit (Quit: Leaving)
 16:20:42 <-> alextu is now known as alextu-meeting
 16:25:43 <tjaalton> vicamo: so, back to iommu.. I'm not really sure :D
 16:26:12 <vicamo> tjaalton: I saw you're merging "NAK: [PATCH 0/2][SRU][B/E/F/U/OEM-OSP1-B/OEM-5.6] PCI: Avoid FLR for AMD Matisse/Starship HD Audio & USB 3.0"?
 16:26:40 --> hughchao_office (hughchao@1.general.hughchao.uk.vpn) has joined #hwe
 16:27:30 <tjaalton> vicamo: oh, that was a mistake.. already replied to the correct thread
 16:27:54 <vicamo> khfeng: are you interested in that power button issue? are holding a conf call
 16:28:04 <khfeng> vicamo, sure
 16:28:06 <vicamo> tjaalton: ok, thanks
 16:28:59 <-- hugh_chao (hughchao@61-220-137-37.HINET-IP.hinet.net) has quit (Ping timeout: 121 seconds)
 16:31:39 <vicamo> khfeng: forwarded conf info for you
 16:32:00 <tjaalton> shane: so what should I do with those patches?
 16:37:18 <khfeng> vicamo, joined via phonecall?
 16:37:21...

Read more...

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (30.4 KiB)

This bug was fixed in the package linux-oem-5.6 - 5.6.0-1018.18

---------------
linux-oem-5.6 (5.6.0-1018.18) focal; urgency=medium

  * focal/linux-oem-5.6: 5.6.0-1018.18 -proposed tracker (LP: #1884496)

  * Focal update: v5.6.18 upstream stable release (LP: #1883304)
    - devinet: fix memleak in inetdev_init()
    - l2tp: add sk_family checks to l2tp_validate_socket
    - l2tp: do not use inet_hash()/inet_unhash()
    - net: check untrusted gso_size at kernel entry
    - net/mlx5: Fix crash upon suspend/resume
    - net: stmmac: enable timestamp snapshot for required PTP packets in dwmac
      v5.10a
    - net: usb: qmi_wwan: add Telit LE910C1-EUX composition
    - NFC: st21nfca: add missed kfree_skb() in an error path
    - nfp: flower: fix used time of merge flow statistics
    - sctp: check assoc before SCTP_ADDR_{MADE_PRIM, ADDED} event
    - virtio_vsock: Fix race condition in virtio_transport_recv_pkt
    - vsock: fix timeout in vsock_accept()
    - net: be more gentle about silly gso requests coming from user
    - net: dsa: felix: send VLANs on CPU port as egress-tagged
    - mptcp: fix unblocking connect()
    - net/sched: fix infinite loop in sch_fq_pie
    - net/mlx5e: replace EINVAL in mlx5e_flower_parse_meta()
    - USB: serial: qcserial: add DW5816e QDL support
    - USB: serial: usb_wwan: do not resubmit rx urb on fatal errors
    - USB: serial: option: add Telit LE910C1-EUX compositions
    - USB: serial: ch341: add basis for quirk detection
    - USB: serial: ch341: fix lockup of devices with limited prescaler
    - iio:chemical:sps30: Fix timestamp alignment
    - iio: vcnl4000: Fix i2c swapped word reading.
    - iio:chemical:pms7003: Fix timestamp alignment and prevent data leak.
    - iio: adc: stm32-adc: fix a wrong error message when probing interrupts
    - usb: musb: start session in resume for host port
    - usb: musb: Fix runtime PM imbalance on error
    - serial: 8250: Enable 16550A variants by default on non-x86
    - vt: keyboard: avoid signed integer overflow in k_ascii
    - tty: hvc_console, fix crashes on parallel open/close
    - staging: rtl8712: Fix IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK
    - CDC-ACM: heed quirk also in error handling
    - nvmem: qfprom: remove incorrect write support
    - x86/cpu: Add a steppings field to struct x86_cpu_id
    - x86/cpu: Add 'table' argument to cpu_matches()
    - x86/speculation: Add Special Register Buffer Data Sampling (SRBDS)
      mitigation
    - x86/speculation: Add SRBDS vulnerability and mitigation documentation
    - x86/speculation: Add Ivy Bridge to affected list
    - uprobes: ensure that uprobe->offset and ->ref_ctr_offset are properly
      aligned
    - Revert "net/mlx5: Annotate mutex destroy for root ns"
    - Linux 5.6.18

  * NULL pointer dereference in nvme reset work-queue when VMD raid mode and
    SecureBoot turned on simultaneously on TigerLake (LP: #1876707)
    - iommu: Use C99 flexible array in fwspec
    - iommu: Define dev_iommu_fwspec_get() for !CONFIG_IOMMU_API
    - ACPI/IORT: Remove direct access of dev->iommu_fwspec
    - drm/msm/mdp5: Remove direct access of dev->iommu_fwspec
    - iommu/tegra-gart: Remove direct access of dev->i...

Changed in linux-oem-5.6 (Ubuntu Focal):
status: Fix Committed → Fix Released
Hsuan-Yu Lin (shanelin)
tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-5.6 - 5.6.0-1020.20

---------------
linux-oem-5.6 (5.6.0-1020.20) focal; urgency=medium

  * focal/linux-oem-5.6: 5.6.0-1020.20 -proposed tracker (LP: #1886753)

  * Realtek [10ec:c82f] Subsystem [17aa:c02f] Wifi adapter not found
    (LP: #1886247)
    - SAUCE: rtw88: 8822ce: add support for device ID 0xc82f

  * [WD19TB] external DP failed with DRM error message (LP: #1886165)
    - drm/i915/tgl: Update TC DP vswing table
    - drm/i915/tgl: Implement WA_16011163337
    - SAUCE: drm/i915/bios: add intel_bios_hdmi_level_shift()
    - drm/i915/tgl: Add HBR and HBR2+ voltage swing table
    - drm/i915/dc3co: Avoid full modeset when EXITLINE needs to be changed
    - drm/i915/tgl+: Use the correct DP_TP_* register instances in MST encoders
    - drm/i915/tgl+: Fix TBT DPLL fractional divider for 38.4MHz ref clock

  * ubuntu_aufs_smoke_test failed on Focal OEM 5.6 (LP: #1879308)
    - SAUCE: fs: Enable aufs

 -- Timo Aaltonen <email address hidden> Wed, 08 Jul 2020 11:44:53 +0300

Changed in linux-oem-5.6 (Ubuntu):
status: Invalid → Fix Released
Changed in hwe-next:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.