Add generic fuzzy matching logic to the database layer

Bug #1881865 reported by haixin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
haixin

Bug Description

share list, share snap list, Fuzzy query by name or description is supported, but the current implementation is first get all the shares, then In the API layer, the for loop is used to achieve fuzzy matching, if the num of shares is big,
It will seriously affect the speed of fuzzy matching.Therefore, we should let the database do the matching to speed up the query.
   i also noticed that in share snap list api, Paging query parameters limit and offset same problem with fuzzy queries,we also need to move those to database layer to deal with it.

haixin (haixin77)
Changed in manila:
assignee: nobody → haixin (haixin77)
Changed in manila:
importance: Undecided → Medium
milestone: none → victoria-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/734041

Changed in manila:
status: New → In Progress
Changed in manila:
milestone: victoria-2 → victoria-3
Changed in manila:
assignee: haixin (haixin77) → Goutham Pacha Ravi (gouthamr)
Changed in manila:
milestone: victoria-3 → victoria-rc1
Changed in manila:
assignee: Goutham Pacha Ravi (gouthamr) → haixin (haixin77)
Changed in manila:
milestone: victoria-rc1 → wallaby-1
Changed in manila:
milestone: wallaby-1 → wallaby-2
Changed in manila:
milestone: wallaby-2 → wallaby-3
tags: added: wallaby-rc-bugsquash
Changed in manila:
milestone: wallaby-3 → wallaby-rc1
Changed in manila:
milestone: wallaby-rc1 → xena-1
tags: added: wallaby-backport-potential
removed: wallaby-rc-bugsquash
Revision history for this message
Vida Haririan (vhariria) wrote :
Changed in manila:
milestone: xena-1 → xena-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/734041
Committed: https://opendev.org/openstack/manila/commit/e032c13bfb0d2ee2bc3c6d4b2adda27b6759a14b
Submitter: "Zuul (22348)"
Branch: master

commit e032c13bfb0d2ee2bc3c6d4b2adda27b6759a14b
Author: haixin <email address hidden>
Date: Mon Jun 8 17:08:51 2020 +0800

    Add generic fuzzy matching logic to the database layer

    share snap list, Fuzzy query by name or description is supported, but
    the current implementation is first get all the shares, then In the API
    layer, the for loop is used to achieve fuzzy matching, if the num of
    shares is big,
    It will seriously affect the speed of fuzzy matching.Therefore, we
    should let the database do the matching to speed up the query.
    Moving the pagination params (limit, offset, sorting) to the database
    layer for snapshot list, to optimize query speed.

    Closes-Bug:#1881865
    Partial-Bug:#1831094

    Change-Id: I283e78c9e7c2dd626d94cf6c1b01d4e2f9ae8097

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 13.0.0.0rc1

This issue was fixed in the openstack/manila 13.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.