ussuri: tempest.api.compute.images.test_images_oneserver_negative.ImagesOneServerNegativeTestJSON

[wes hayutin]

2020-06-01 00:41:05,471 280103 INFO [tempest.common.waiters] State transition "BUILD/spawning" ==> "ACTIVE/None" after 8 second wait
}}}

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/tempest/api/compute/images/test_images_oneserver_negative.py", line 114, in test_create_second_image_when_first_image_is_being_saved
    self.server_id)
  File "/usr/lib/python3.6/site-packages/testtools/testcase.py", line 485, in assertRaises
    self.assertThat(our_callable, matcher)
  File "/usr/lib/python3.6/site-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: <bound method BaseV2ComputeTest.create_image_from_server of <class 'tempest.api.compute.images.test_images_oneserver_negative.ImagesOneServerNegativeTestJSON'>> returned {}

https://logserver.rdoproject.org/openstack-periodic-latest-released/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-ussuri/16634ea/logs/undercloud/var/log/tempest/stestr_results.html.gz

[sean mooney (sean-k-mooney)]

the test is not correct

https://github.com/openstack/tempest/blob/348fa311fe031ff7d04f41aa9e6ac65f6f6391fe/tempest/api/compute/images/test_images_oneserver_negative.py#L109-L114

is a race.
if the first image saves quickly or has not started yet then the second call can succeed without raising an exception.

we should likely remove this form tempest and instead test this with a functional test in nova as we will not be able to reliably gauntee the image will still be saving in tempest.

i suspect this only passed because of slow performance of glance/nova in the gate.

[Ghanshyam Mann (ghanshyammann)]

yeah, we did fix that in another test and need for this test also. basically if we find the second operation does not find image in SAVING state then skip the test instead of failing. and only run the tests when image is founda in saving state.

[sean mooney (sean-k-mooney)]

unfortunetly that is still a race.

if you check its in saving and then decied to trigger the test by starting another save, by the time you do that it could have finished.

the only way that i can think of to do this correctly would be to develop a testing plugin for glance that would add a delay to the image import e.g. a plugin that just did a sleep 30 or something like that. then we could tune the dealy for our ci env and ensure we dont race.

[sean mooney (sean-k-mooney)]

better then a sleep would be like a webhook or callback url that we could hit to unpause but you get the idea. if we keep this test we need a way to guarentee that we tirgger teh conflict.
if we cant do that with tempest then we should just do this as a functional test in glance or nova.

[Soniya Murlidhar Vyas (svyas)]

If we observe the latest run of periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-ussuri - https://review.rdoproject.org/zuul/builds?job_name=periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-ussuri#

The results are passing.

More info:-
https://review.rdoproject.org/zuul/builds?job_name=periodic-tripleo-ci-centos-8-standalone-full-tempest-api-ussuri

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tempest 25.0.1 release.

[Martin Kopec (mkopec)]

For the record, the test got skipped by this review on June 15th 2020:
https://review.opendev.org/c/openstack/tempest/+/733154

The test got fixed now by:
https://review.opendev.org/c/openstack/tempest/+/735631

If there is not other action needed from tripleo side, this bug can be closed as 'Fix Released'

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tempest 26.1.0 release.

[Marios Andreou (marios-b)]

This is an automated action. Bug status has been set to 'Incomplete' and target milestone has been removed due to inactivity. If you disagree please re-set these values and reach out to us on freenode #tripleo

[Launchpad Janitor (janitor)]

[Expired for tripleo because there has been no activity for 60 days.]