Typo in staff/circ/hold/app.js

Bug #1881012 reported by Garry Collum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

Typo in Open-ILS/web/js/ui/default/staff/circ/holds/app.js

currently in line 65 'legnth' instead of 'length'

      // if in clear mode...
  64 if (clear_mode && holds.length) {
  65 if (!all_holds.legnth) all_holds = holds;
  66 holds = holds.filter(function(h) { return h.hold.clear_me });

tags: added: bitesize cleanup
Revision history for this message
Terran McCanna (tmccanna) wrote :
Changed in evergreen:
status: New → Confirmed
tags: added: pullrequest
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

I tested this out and it looks good. I couldn't see that it changed any behavior, switching back and forth between all and clearable holds didn't seem like it would ever trigger that check, all_holds was always empty when the clear flag was set.

I have tested this code and consent to signing off on it with my name,
Josh Stompro and my email address, <email address hidden>.

Josh

tags: added: signedoff
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Pushed to master. Thanks, Terran and Josh!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
milestone: none → 3.9.1
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.